-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create RPC delete collaborator #6489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspcr
added
c/identity server
This is related to the Identity Server
technical debt
Not necessarily broken, but could be done better/cleaner
labels
Aug 29, 2023
nicholaspcr
requested review from
adriansmares and
johanstokking
as code owners
August 29, 2023 16:56
This was referenced Aug 29, 2023
nicholaspcr
force-pushed
the
issue/6314-rpc-delete-membership
branch
from
August 31, 2023 00:20
6195205
to
e266ebe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general.
nicholaspcr
force-pushed
the
issue/6314-rpc-delete-membership
branch
from
August 31, 2023 11:04
e266ebe
to
e60b0d7
Compare
nicholaspcr
force-pushed
the
issue/6314-rpc-delete-membership
branch
from
August 31, 2023 11:27
e60b0d7
to
92ebbce
Compare
adriansmares
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed over it; you can merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c/identity server
This is related to the Identity Server
technical debt
Not necessarily broken, but could be done better/cleaner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #6314
Changes
Testing
Update on unit tests and manual tests via the changes done on PRs that will be linked shortly.
Steps to reproduce and test the changes.
Since this will be merge only when all the subsequent PRs are approved, it means that the Console and CLI will be calling the new route. So in order to test just add and delete a collaborator to the entities mentioned in the changes section.
Nevertheless I will write some more detailed steps on the referenced issue.
Regressions
New rpc service and it does not change the behavior of the update route, there should not be any regressions.
Notes for Reviewers
Broke this into smaller PRs in order to avoid having huge PRs.
Didn't add anything on the
CHANGELOG
since this is mostly internal. It is probably worth adding that deletion of collaborators won't be able to be performed via theupdate
route but that will only happen on a major release.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.