Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handleDelete of Collaborators in Console #6491

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

nicholaspcr
Copy link
Contributor

Summary

References #6489

Tried making a change on the Console so it uses the new HTTP route to perform collaborator deletion.

Changes

  • Update collaborator-form's handleDelete
  • Update collaborator actions

Testing

Manual testing and cypress tests should not break with this change.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr added c/console This is related to the Console technical debt Not necessarily broken, but could be done better/cleaner labels Aug 29, 2023
@nicholaspcr nicholaspcr added this to the v3.27.2 milestone Aug 29, 2023
@nicholaspcr nicholaspcr self-assigned this Aug 29, 2023
@github-actions github-actions bot added ui/web This is related to a web interface and removed c/console This is related to the Console labels Aug 29, 2023
@nicholaspcr
Copy link
Contributor Author

On a different note, while looking at the sdk I noticed that

// TODO: Remove this once https://github.com/TheThingsNetwork/lorawan-stack/issues/4766 is resolved.
if (this.key.endsWith('_at') && e === '0001-01-01T00:00:00Z') {
return
}
is still present but the issue is closed. Thought it was worth mentioning.

@kschiffer kschiffer mentioned this pull request Aug 30, 2023
6 tasks
pkg/webui/containers/collaborator-form/index.js Outdated Show resolved Hide resolved
pkg/webui/lib/store/middleware/collaborators.js Outdated Show resolved Hide resolved
@nicholaspcr nicholaspcr force-pushed the issue/6314-rpc-delete-membership branch from 6195205 to e266ebe Compare August 31, 2023 00:20
@nicholaspcr nicholaspcr force-pushed the issue/6314-rpc-delete-membership branch 2 times, most recently from e60b0d7 to 92ebbce Compare August 31, 2023 11:27
@nicholaspcr nicholaspcr force-pushed the issue/6314-console-delete-collaborator branch from 653a322 to 48f80c7 Compare August 31, 2023 11:28
@nicholaspcr nicholaspcr requested review from kschiffer and removed request for johanstokking and adriansmares August 31, 2023 11:28
@nicholaspcr nicholaspcr force-pushed the issue/6314-console-delete-collaborator branch from 48f80c7 to fc7792b Compare August 31, 2023 11:55
Base automatically changed from issue/6314-rpc-delete-membership to v3.27 September 1, 2023 19:43
@nicholaspcr nicholaspcr merged commit cd6c67d into v3.27 Sep 1, 2023
12 checks passed
@nicholaspcr nicholaspcr deleted the issue/6314-console-delete-collaborator branch September 1, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants