Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLI rpc service used in delete collaborator command #6490

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Update CLI rpc service used in delete collaborator command #6490

merged 1 commit into from
Sep 1, 2023

Conversation

nicholaspcr
Copy link
Contributor

Summary

References #6489

Changes

  • Update commands that perform collaborator deletion, replace SetCollaborator with DeleteCollaborator

Testing

Manual testing

Regressions

There should be none, very isolated change on the interaction between CLI and IS.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr added ui/cli This is related to ttn-lw-cli technical debt Not necessarily broken, but could be done better/cleaner labels Aug 29, 2023
@nicholaspcr nicholaspcr added this to the v3.27.2 milestone Aug 29, 2023
@nicholaspcr nicholaspcr self-assigned this Aug 29, 2023
@nicholaspcr nicholaspcr force-pushed the issue/6314-rpc-delete-membership branch from 6195205 to e266ebe Compare August 31, 2023 00:20
@nicholaspcr nicholaspcr force-pushed the issue/6314-rpc-delete-membership branch from e266ebe to e60b0d7 Compare August 31, 2023 11:04
@nicholaspcr nicholaspcr force-pushed the issue/6314-cli-delete-membership branch from 56b7668 to e268e5b Compare August 31, 2023 11:04
@nicholaspcr nicholaspcr force-pushed the issue/6314-rpc-delete-membership branch from e60b0d7 to 92ebbce Compare August 31, 2023 11:27
@nicholaspcr nicholaspcr force-pushed the issue/6314-cli-delete-membership branch from e268e5b to c98268a Compare August 31, 2023 11:28
@nicholaspcr nicholaspcr removed the request for review from johanstokking August 31, 2023 11:28
Base automatically changed from issue/6314-rpc-delete-membership to v3.27 September 1, 2023 19:43
@nicholaspcr nicholaspcr merged commit 8af1a0e into v3.27 Sep 1, 2023
4 checks passed
@nicholaspcr nicholaspcr deleted the issue/6314-cli-delete-membership branch September 1, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansmares adriansmares adriansmares approved these changes

Assignees

@nicholaspcr nicholaspcr

Labels
technical debt Not necessarily broken, but could be done better/cleaner ui/cli This is related to ttn-lw-cli
Projects
None yet
Milestone
v3.27.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaspcr @adriansmares