Bump Kokkos version to 4.3.01 #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
|
[sc-63118] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #725 +/- ##
==========================================
+ Coverage 93.36% 99.15% +5.78%
==========================================
Files 116 134 +18
Lines 16815 18989 +2174
==========================================
+ Hits 15699 18828 +3129
+ Misses 1116 161 -955 ☔ View full report in Codecov by Sentry. |
vincentmr
reviewed
May 15, 2024
pennylane_lightning/core/src/simulators/lightning_kokkos/gates/GateFunctorsGenerator.hpp
Outdated
Show resolved
Hide resolved
maliasadi
reviewed
May 15, 2024
pennylane_lightning/core/src/simulators/lightning_kokkos/gates/GateFunctorsGenerator.hpp
Outdated
Show resolved
Hide resolved
mlxd
added
ci:use-multi-gpu-runner
…nto update/kokkos_version
…ane-lightning into update/kokkos_version
vincentmr
approved these changes
May 16, 2024
There was a problem hiding this comment.
I've added a tag to docker-build on the present branch, but it is failing because we are still building on an ad hoc branch of Kokkos. I have a PR #722 which fixes some issues in the Dockerfile. I think I should update the Dockerfile to work with Kokkos 4.3 there.
| @@ -482,7 +482,7 @@ row-major format. | |||
| */ | |||
| template <template <typename...> class ComplexT, typename T> | |||
| static auto getCRot(T phi, T theta, T omega) -> std::vector<ComplexT<T>> { | |||
| const auto rot{std::move(getRot<ComplexT, T>(phi, theta, omega))}; | |||
| const auto rot{getRot<ComplexT, T>(phi, theta, omega)}; | |||
multiphaseCFD
approved these changes
May 17, 2024
|
Thanks folks. Ignoring the existing CF error, as it seems like we are optimal for now. |
multiphaseCFD
pushed a commit
that referenced
this pull request
May 17, 2024
* Bump Kokkos version * Auto update version from '0.37.0-dev6' to '0.37.0-dev8' * Auto update version from '0.37.0-dev8' to '0.37.0-dev9' * Replace all Kokkos versions with 4.3 to update cache * Auto update version from '0.37.0-dev9' to '0.37.0-dev10' * Update changelog * Auto update version from '0.37.0-dev11' to '0.37.0-dev12' * Auto update version from '0.37.0-dev12' to '0.37.0-dev13' * Fix warning: moving a temporary object prevents copy elision * Ensure kokkos_swap used throughout * Auto update version from '0.37.0-dev13' to '0.37.0-dev14' --------- Co-authored-by: ringo-but-quantum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Building Catalyst currently causes issues with Kokkos path resolution. This PR aims to update the Kokkos version to offer a potential route to rectify this issue.
Description of the Change: Updates kokkos to 4.3.01
Benefits: New support for Kokkos architectures and performance gains. Potential fix for Catalyst runtime Kokkos failure.
Possible Drawbacks:
Related GitHub Issues: PennyLaneAI/catalyst#732