-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Runtime] Add support for Lightning source directory to be used in runtime build #732
Conversation
[sc-63110] |
Hello. You may have forgotten to update the changelog!
|
Exploring whether PennyLaneAI/pennylane-lightning#725 will fix Kokkos failures UPDATE: No further LK issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve 💯 Would love to figure the pybind/findpython issue at some point though if you have time.
Sounds good. Yea, I'll do some delving once time permits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlxd! This would be also beneficial for testing the runtime with pre-compiled Kokkos kernels 🚀
Context: This PR allows Lightning to be cloned and used in-place with Catalyst's runtime, allowing faster turnaround and development against both packages.
In addition, it overcomes some issues with Python package issues observed at build time by updating the runtime pybind11 and requiring Python to be found before proceeding.<\del>Description of the Change: Added
LIGHTNING_SRC_PATH
CMake argument to specify a full path to a local Lightning repository, and all source will be used in place for a runtime build.Benefits: Enables faster turnaround for development between Lightning and Catalyst. Can allow a multi-version clone of each repo and compilation steps to be validated and tested.
Possible Drawbacks:
Related GitHub Issues: