Fix PennyLane LightningKokkos and LightningQubits tests for stable/stable #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
AmintorDusko
force-pushed
the
check/LKokkos_stable_stable
branch
from
2cb2569
to
66b6cb4
Compare
AmintorDusko
force-pushed
the
check/LKokkos_stable_stable
branch
from
7b334b5
to
fe68382
Compare
AmintorDusko
force-pushed
the
check/LKokkos_stable_stable
branch
from
ba8b60b
to
341ba30
Compare
AmintorDusko
force-pushed
the
check/LKokkos_stable_stable
branch
from
27ac6da
to
a63c168
Compare
AmintorDusko
force-pushed
the
check/LKokkos_stable_stable
branch
from
422d323
to
b895d51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
===========================================
- Coverage 87.20% 57.29% -29.91%
===========================================
Files 83 16 -67
Lines 11875 1829 -10046
===========================================
- Hits 10355 1048 -9307
+ Misses 1520 781 -739 ☔ View full report in Codecov by Sentry. |
mlxd
reviewed
May 17, 2024
AmintorDusko
changed the title
multiphaseCFD
approved these changes
May 21, 2024
multiphaseCFD
pushed a commit
that referenced
this pull request
May 22, 2024
…able (#734) * comment pennylane master out * make Kokkos version configurable; checkout stable tag * re-trigger CIs * uncomment pennylane master * fix wrong condition * update version * fix for lqpu #732 * update lkcuda workflow and leave some notes to remember to change it back later * update stable branch to latest_release * checkout latest_release on LQubit tests [skip ci] * Trigger CIs * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: PennyLane LightningKokkos and LightningQubits tests for stable/stable configuration are currently failing.
This PR looks to solve these problems.
Description of the Change:
The LightningKokkos and LightningQubits stable configurations (v0.36.0) were wrongly being tested with the most recent suite of tests.
PR #725 changed the default Kokkos version used by the LKokkos device. Currently, we build all wheels from scratch in our Plugin Test Matrix workflows, the sum of these two factors led me to expand our Kokkos caching functionality to build and cache any number of Kokkos versions. This is now configurable by an input variable
kokkos_version.I brought the change proposed by @vincentmr to this PR so we can have everything in a single place, to see if it is possible to merge it sooner than later.
Benefits: Tests are now right.
[sc-63561]