fix(shared-data): Re-apply update tip overlap values for Flex Pipettes (#15147) #15284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
added
the
DO NOT MERGE
sfoster1
force-pushed
the
chore-update-tip-overlap
branch
from
6fa6494
to
cab20f6
Compare
sfoster1
removed
the
DO NOT MERGE
SyntaxColoring
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Approved previously in #15147, looks good if and when the versioning considerations are solved.
sfoster1
force-pushed
the
chore-update-tip-overlap
branch
3 times, most recently
from
a32d587
to
be140b8
Compare
After conducting hardware testing, we've formulated updated tip overlap values for every tip size and pipette model. These adjustments apply to 1-channel, 8-channel, and 96-channel pipettes. These revised values aim to mitigate overpressure occurrences in ABR. [https://docs.google.com/spreadsheets/d/16dEmqulO4SIKU6E0aYTfVQEnZRTn3MwNF_WB8K1KmRM/edit#gid=0](url) - Added v2 tip overlap values for all flex pipette-tip combos
sfoster1
force-pushed
the
chore-update-tip-overlap
branch
from
be140b8
to
f4c790e
Compare
Change API version 2.19 to use the new tip overlap values that should reduce overpressure errors. Closes EXEC-452
Carlos-fernandez
approved these changes
Jun 5, 2024
DerekMaggio
suggested changes
Jun 5, 2024
| @@ -12,6 +12,7 @@ | |||
| ENGINE_CORE_API_VERSION: Final = APIVersion(2, 14) | |||
| SET_OFFSET_RESTORED_API_VERSION: Final = APIVersion(2, 18) | |||
|
|
|||
|
|
|||
skowalski08
approved these changes
Jun 5, 2024
DerekMaggio
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #15147 again but this time outside the context of an extremely imminent release.
While this code needs to be merged, we should carefully consider how we do so. We can't ship this until we can separate this behavior by API level so that customers who may have tuned in offsets based on the old incorrect tip offsets won't have their protocols invalidated - this data needs to be loaded by API level.
Closes EXEC-452