Translated F77 and F90 examples to F2003 examples (with one new addition in IDA) #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmm16
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
|
In general, when we update any package (ARKODE, CVODE, etc.), the PR should include:
Here, you could say something like "Numerous previous Fortran-77 and Fortran-90 example programs were updated to use SUNDIALS current Fortran-2003 interfaces." |
drreynolds
requested changes
Jul 12, 2023
drreynolds
previously requested changes
Jul 17, 2023
…ders where necessary.
example_utilities.hpp requires `stoi` and similar methods. These are declared in `<string>`, but `<string>` is not included. This means this file will break any TU it's included in. Resolves LLNL#330 Co-authored-by: Cody Balos <[email protected]>
Fixes LLNL#335 Co-authored-by: David Gardner <[email protected]>
…NL#337) Fixes LLNL#333. Some other typedefs already had specialized (towards idas or cvodes) prefixed names, it won't harm to generalize this. --------- Co-authored-by: Cody Balos <[email protected]>
Add scripts for comparing benchmark and example timings against release timings and a notebook using Thicket to visualize data --------- Co-authored-by: David J. Gardner <[email protected]> Co-authored-by: Cody J. Balos <[email protected]>
Fixes part of LLNL#253 by avoiding nested loops that take `O(M*N)` operations. Also fixes LLNL#256. --------- Signed-off-by: phannebohm <[email protected]> Co-authored-by: Cody Balos <[email protected]>
…ed CMakeLists.txt accordingly
Add core error handling functions and macros --------- Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: David J. Gardner <[email protected]>
Apply clang-format and clang-tidy. There are changes/additions in the following files: - .clang-format - .clang-tidy - .github/actions/free-space-ubuntu/action.yml - .github/workflows/build-llvm-container.yml - .github/workflows/check-clang-format.yml - cmake/SundialsSetupCompilers.cmake - scripts/format.sh - scripts/tidy_and_format.sh --------- Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: David J. Gardner <[email protected]>
…e the new F2003 examples
…f2003-examples into feature/f2003-examples
drreynolds
previously approved these changes
Dec 14, 2023
gardner48
added a commit
that referenced
this pull request
Dec 18, 2023
Remove F77 interface examples from `develop` branch. Once this PR is merged, a new `archive` branch can be created for easy reference until #302 is merged and the `archive` branch can be deleted. --------- Co-authored-by: Cody Balos <[email protected]>
balos1
added a commit
that referenced
this pull request
Dec 18, 2023
Remove F77 interface examples from `develop` branch. Once this PR is merged, a new `archive` branch can be created for easy reference until #302 is merged and the `archive` branch can be deleted. --------- Co-authored-by: Cody Balos <[email protected]>
gardner48
dismissed
drreynolds’s stale review
The merge-base changed after approval.
Merged
|
Closing this PR, as it is replaced by #420. |
balos1
added a commit
that referenced
this pull request
Feb 21, 2024
This PR replaces #302, since it proved way too difficult to merge changes from `develop` directly into that branch, so I just propagated the new/changed files from #302 into a new branch off of `develop`. --------- Co-authored-by: Cody Balos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 22 examples (+ old names & positions) include:
arkode/F77_serial/fark_diurnal_kry_bp.f
arkode/F77_serial/fark_roberts_dnsL.f
arkode/F77_serial/fark_roberts_dns.f
arkode/F90_serial/ark_bruss1D_FEM_klu.f90
arkode/F90_serial/ark_bruss.f90
cvode/fcmix_serial/fcvAdvDiff_bnd.f
cvode/fcmix_serial/fcvDiurnal_kry.f
cvode/fcmix_serial/fcvDiurnal_kry_bp.f
cvode/fcmix_serial/fcvRoberts_dns.f
cvode/fcmix_serial/fcvRoberts_dnsL.f
cvode/fcmix_serial/fcvRoberts_dns_constraints.f
cvode/fcmix_serial/fcvRoberts_klu.f
kinsol/fcmix_serial/fkinDiagon_kry.f
Create ida/fcmix_openmp/fidaHeat2D_kry_openmp.f
arkode/F77_parallel/fark_diag_kry_bbd_p.f
arkode/F77_parallel/fark_diag_non_p.f
arkode/F90_parallel/fark_heat2D.f90
cvode/fcmix_parallel/fcvDiag_kry_bbd_p.f
cvode/fcmix_parallel/fcvDiag_kry_p.f
cvode/fcmix_parallel/fcvDiag_non_p.f
ida/fcmix_parallel/fidaHeat2D_kry_bbd_p.f
kinsol/fcmix_parallel/fkinDiagon_kry_p.f