Translated F77 and F90 examples to F2003 examples (with one new addition in IDA)

.clang-format

@@ -116,7 +116,7 @@ PenaltyReturnTypeOnItsOwnLine       : 10000  # (penalize more)
 PointerAlignment                    : Left
 QualifierAlignment                  : Leave
 ReferenceAlignment                  : Pointer
-ReflowComments                      : true
+ReflowComments                      : false
 SeparateDefinitionBlocks            : Always
 SortIncludes                        : true
 SortUsingDeclarations               : true
@@ -140,7 +140,6 @@ SpacesInConditionalStatement        : false
 SpacesInContainerLiterals           : true
 SpacesInParentheses                 : false
 SpacesInSquareBrackets              : false
-SpaceBeforeSquareBrackets           : false
 Standard                            : c++14
 TabWidth: 2
 UseCRLF : false

.clang-tidy

@@ -13,7 +13,8 @@
 # This should be applied to all new code. See the developer documentation.
 # ------------------------------------------------------------------------------
 ---
-Checks: '-*,clang-diagnostic-*,clang-analyzer-*,cppcoreguidelines-*,-cppcoreguidelines-explicit-virtual-functions,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-avoid-magic-numbers,google-*,-google-explicit-constructor,modernize-*,-modernize-use-trailing-return-type,mpi-*,readability-*,-readability-magic-numbers,-readability-identifier-length'
+#Checks: '-*,clang-diagnostic-*,clang-analyzer-*,cppcoreguidelines-*,-cppcoreguidelines-explicit-virtual-functions,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-avoid-magic-numbers,google-*,-google-explicit-constructor,modernize-*,-modernize-use-trailing-return-type,mpi-*,readability-*,-readability-magic-numbers,-readability-identifier-length'
+Checks: '-*,readability-braces-around-statements'
 WarningsAsErrors: ''
 HeaderFilterRegex: ''
 AnalyzeTemporaryDtors: false

.github/actions/free-space-ubuntu/action.yml

@@ -0,0 +1,31 @@
+name: Free space on Ubuntu VMs
+description: Frees up disk space on GitHub Actions Ubuntu VMs
+
+runs:
+  using: composite
+  steps:
+    - id: show-space
+      run: df -h
+      shell: bash
+    - id: free-up
+      run: |
+        sudo rm -rf /usr/local/lib/android || true
+        sudo rm -rf /usr/share/dotnet || true
+        sudo rm -rf /opt/ghc || true
+        sudo rm -rf /usr/local/.ghcup || true
+        sudo apt-get remove -y '^aspnetcore-.*' || echo "::warning::The command [sudo apt-get remove -y '^aspnetcore-.*'] failed to complete successfully. Proceeding..."
+        sudo apt-get remove -y '^dotnet-.*' --fix-missing || echo "::warning::The command [sudo apt-get remove -y '^dotnet-.*' --fix-missing] failed to complete successfully. Proceeding..."
+        sudo apt-get remove -y '^llvm-.*' --fix-missing || echo "::warning::The command [sudo apt-get remove -y '^llvm-.*' --fix-missing] failed to complete successfully. Proceeding..."
+        sudo apt-get remove -y 'php.*' --fix-missing || echo "::warning::The command [sudo apt-get remove -y 'php.*' --fix-missing] failed to complete successfully. Proceeding..."
+        sudo apt-get remove -y '^mongodb-.*' --fix-missing || echo "::warning::The command [sudo apt-get remove -y '^mongodb-.*' --fix-missing] failed to complete successfully. Proceeding..."
+        sudo apt-get remove -y '^mysql-.*' --fix-missing || echo "::warning::The command [sudo apt-get remove -y '^mysql-.*' --fix-missing] failed to complete successfully. Proceeding..."
+        sudo apt-get remove -y azure-cli google-chrome-stable firefox powershell mono-devel libgl1-mesa-dri --fix-missing || echo "::warning::The command [sudo apt-get remove -y azure-cli google-chrome-stable firefox powershell mono-devel libgl1-mesa-dri --fix-missing] failed to complete successfully. Proceeding..."
+        sudo apt-get remove -y google-cloud-sdk --fix-missing || echo "::debug::The command [sudo apt-get remove -y google-cloud-sdk --fix-missing] failed to complete successfully. Proceeding..."
+        sudo apt-get remove -y google-cloud-cli --fix-missing || echo "::debug::The command [sudo apt-get remove -y google-cloud-cli --fix-missing] failed to complete successfully. Proceeding..."
+        sudo apt-get autoremove -y || echo "::warning::The command [sudo apt-get autoremove -y] failed to complete successfully. Proceeding..."
+        sudo apt-get clean || echo "::warning::The command [sudo apt-get clean] failed to complete successfully. Proceeding..."
+        sudo docker image prune --all --force || true
+      shell: bash
+    - id: show-space-again
+      run: df -h
+      shell: bash

.github/actions/test-driver/action.yml

@@ -26,5 +26,5 @@ runs:
       run: |
         git config --global --add safe.directory $GITHUB_WORKSPACE
         cd test
-        ./test_driver.sh --testtype CUSTOM --env env/docker.sh --tpls --realtype ${{ inputs.precision }} --indexsize ${{ inputs.indexsize }}
+        ./test_driver.sh --testtype CUSTOM --env env/docker.sh --tpls --sunrealtype ${{ inputs.precision }} --indexsize ${{ inputs.indexsize }}
       shell: bash

.github/workflows/build-llvm-container.yml

@@ -0,0 +1,38 @@
+name: Containers - build llvm container for clang-format checker
+
+on:
+  workflow_dispatch:
+
+jobs:
+  build_llvm_container:
+    runs-on: ubuntu-22.04
+    steps:    
+      - name: Check out repository code
+        uses: actions/checkout@v4
+
+      - name: Free up disk space
+        uses: ./.github/actions/free-space-ubuntu
+
+      - name: Checkout Spack
+        uses: actions/checkout@v4
+        with:
+          repository: spack/spack
+          ref: v0.21.0
+          path: spack
+
+      - name: Setup Spack
+        run: echo "$PWD/spack/bin" >> "$GITHUB_PATH"
+
+      - name: Setup Spack Binary Cache
+        run: |
+          spack mirror add v0.21.0 https://binaries.spack.io/v0.21.0
+          spack mirror add --oci-username ${{ github.actor }} --oci-password ${{ secrets.OCI_TOKEN }} sundials_spack_cache oci://ghcr.io/LLNL/sundials_spack_cache
+          spack buildcache keys --install --trust 
+
+      - name: Install [email protected]
+        run: spack install --no-check-signature [email protected]
+
+      - name: Push to buildcache
+        if: ${{ !cancelled() }}
+        run: |
+          spack buildcache push --force --base-image ubuntu:22.04 sundials_spack_cache llvm

.github/workflows/check-clang-format.yml

@@ -0,0 +1,47 @@
+name: Checks - clang-format
+
+on:
+  push:
+  pull_request:
+  workflow_dispatch:
+
+jobs:
+  clang_format_check:
+    runs-on: ubuntu-latest
+    container:
+      image: ghcr.io/llnl/sundials_spack_cache:llvm-17.0.4-h4lflucc3v2vage45opbo2didtcuigsn.spack
+    steps:
+      - name: Install git
+        run: | 
+          apt update
+          apt install -y git
+
+      - name: Check out repository code
+        uses: actions/checkout@v4
+        with:
+          submodules: true
+
+      - name: Add safe directory
+        run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
+
+      - name: Print clang-format version
+        run: clang-format --version
+
+      - name: Run checker on code
+        run: |
+          ./scripts/format.sh .
+
+      - name: Run git diff to see if anything changed
+        run: /usr/bin/git diff --name-only --exit-code
+
+      - name: Run git diff if we failed
+        if: failure()
+        run:  /usr/bin/git diff > diff
+
+      - name: Archive diff if we failed
+        uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: diff
+          path: |
+            ${{ github.workspace }}/diff

.github/workflows/double-precision.yml

@@ -1,9 +1,15 @@
 #
-name: double precision build and test with GCC+TPLs (no GPUs)
+name: Build and Test - Ubuntu/gcc double precision (TPLs, no GPUs)
 
 on:
   push:
   pull_request:
+  merge_group:
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
   build_and_test:
@@ -15,6 +21,7 @@ jobs:
       matrix:
         indexsize: [32, 64]
         precision: ['double']
+        buildtype: ['Debug', 'Release']
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
@@ -25,10 +32,20 @@ jobs:
         with:
           indexsize: ${{ matrix.indexsize }}
           precision: ${{ matrix.precision }}
-      - name: Archive files from failed build
-        uses: actions/[email protected]
+        env:
+          CMAKE_BUILD_TYPE: ${{ matrix.buildtype }}
+      - name: Archive build files from failed build
+        uses: actions/upload-artifact@v3
         if: failure()
         with:
           name: build_files
           path: |
             ${{ github.workspace }}/test/build_*
+            !${{ github.workspace }}/test/build_*/Testing/output
+      - name: Archive output files from failed build
+        uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: output_files
+          path: |
+            ${{ github.workspace }}/test/build_*/Testing/

.github/workflows/extended-precision.yml

@@ -1,8 +1,14 @@
 #
-name: extended precision build and test with GCC+TPLs (no GPUs)
+name: Build and Test - Ubuntu/gcc extended precision (TPLs, no GPUs)
 
 on:
   pull_request:
+  merge_group:
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
   build_and_test:
@@ -24,10 +30,19 @@ jobs:
         with:
           indexsize: ${{ matrix.indexsize }}
           precision: ${{ matrix.precision }}
-      - name: Archive files from failed build
-        uses: actions/upload-artifact@v2.2.4
+      - name: Archive build files from failed build
+        uses: actions/upload-artifact@v3
         if: failure()
         with:
           name: build_files
           path: |
             ${{ github.workspace }}/test/build_*
+            !${{ github.workspace }}/test/build_*/Testing/output
+      - name: Archive output files from failed build
+        uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: output_files
+          path: |
+            ${{ github.workspace }}/test/build_*/Testing/
+

.github/workflows/macos-latest.yml

@@ -1,14 +1,20 @@
-name: MacOS short test
+name: Build and Test - MacOS (short)
 
 on:
   pull_request:
+  merge_group:
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)
   BUILD_TYPE: Release
 
 jobs:
-  build:
+  build_and_test:
     # The CMake configure and build commands are platform agnostic and should work equally
     # well on Windows or Mac.  You can convert this to a matrix build if you need
     # cross-platform coverage.

.github/workflows/single-precision.yml

@@ -1,8 +1,14 @@
 #
-name: single precision build and test with GCC+TPLs (no GPUs)
+name: Build and Test - Ubuntu/gcc single precision (TPLs, no GPUs)
 
 on:
   pull_request:
+  merge_group:
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
   build_and_test:
@@ -24,10 +30,19 @@ jobs:
         with:
           indexsize: ${{ matrix.indexsize }}
           precision: ${{ matrix.precision }}
-      - name: Archive files from failed build
-        uses: actions/upload-artifact@v2.2.4
+      - name: Archive build files from failed build
+        uses: actions/upload-artifact@v3
         if: failure()
         with:
           name: build_files
           path: |
             ${{ github.workspace }}/test/build_*
+            !${{ github.workspace }}/test/build_*/Testing/output
+      - name: Archive output files from failed build
+        uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: output_files
+          path: |
+            ${{ github.workspace }}/test/build_*/Testing/
+

.github/workflows/spack-develop.yml

@@ -1,12 +1,17 @@
 #
-name: spack@develop build and test with GCC+TPLs (no GPUs)
+name: Build and Test - Ubuntu/gcc spack@develop (TPLs, no GPUs)
 
 on:
   pull_request:
+  merge_group:
   workflow_dispatch:
   schedule:
   - cron: '00 22 * * *'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   build_and_test:
     runs-on: ubuntu-latest
@@ -27,10 +32,18 @@ jobs:
         with:
           indexsize: ${{ matrix.indexsize }}
           precision: ${{ matrix.precision }}
-      - name: Archive files from failed build
-        uses: actions/upload-artifact@v2.2.4
+      - name: Archive build files from failed build
+        uses: actions/upload-artifact@v3
         if: failure()
         with:
           name: build_files
           path: |
             ${{ github.workspace }}/test/build_*
+            !${{ github.workspace }}/test/build_*/Testing/output
+      - name: Archive output files from failed build
+        uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: output_files
+          path: |
+            ${{ github.workspace }}/test/build_*/Testing/