Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example guide CVODE update (currently without Deep Dive) #309

Closed
wants to merge 78 commits into from
Closed

Example guide CVODE update (currently without Deep Dive) #309

wants to merge 78 commits into from

Conversation

danmm16
Copy link

@danmm16 danmm16 commented Jul 24, 2023

Added example documentation in RestructuredText for CVODE. Complete aside from the deep dive that was promised.

danmm16 and others added 30 commits June 5, 2023 13:27
@danmm16
Added 2 examples for ARKODE.
06f845c
@drreynolds
Debugged ark_bruss_f2003 and created output file
57a2ea0
@danmm16
Added templates for 2 more arkode Fortran examples and added them to …
2557a09 
…the CMAKE file.
@danmm16
added a bit to the template for bruss1D
cc455c9
@danmm16
Polished off the template, need to copy functions to ode_mod for impl…
42a474f 
…icit, explicit, jacobian, and mass matrix.
@danmm16
fixed minor variable business
43601c7
@drreynolds
Added comments about suggested changes
87e7ca6
@drreynolds
Added comments about suggested changes
0826ba4
@danmm16
finished ark_roberts_dsnL in F2003_serial and made progress on ark_br…
b401af5 
…uss1D
@danmm16
Updated and mostly finished, without testing, ark_diurnal_kry_bp and …
c6d02cb 
…ark_bruss1D. There are now four more translated Fortran examples available for review.
@danmm16
Fixed the Fortran 2003 Serial sphinx documentation code.
a8b44b2
@drreynolds
Fixes from meeting
f353ce4
@drreynolds
Debugged ark_roberts_dns_f2003.f90
d9e7dc5
@drreynolds
Resolved build issues with ark_diurnal_kry_bp_f2003
0a32403
@drreynolds
Added missing call to close the output file stream
0dd6591
@danmm16
Fixed some bugs with F2003 example ark_diurnal and started working on…
c50a015 
… CVODE roberts examples, successfully adding templates for three of them.
@drreynolds
Added comments on some missing pieces
4bbd90c
@balos1
add lapackdense f2003 interface
675c4e6
@danmm16
Finished three more CVODE example F2003 codes.
2aaedab
@danmm16
Updated LAPACK for Fortran 2003. Merge branch 'LAPACK_update' into de…
8624568 
…velop.
@danmm16
Started working on CVODE Sphinx documentation code using ARKODE templ…
fadc77a 
…ate.
@drreynolds
Removed 'built' cvode Sphinx example guide
262d31a
@drreynolds
Removed non-compiling example
2d9780b
@drreynolds
Updates from meeting
28bd101
@drreynolds
Reorganized CVODE example guide files
60455e6
@danmm16
Stashed changes and finished roberts_klu.
b5cfdca
@drreynolds
Fixed duplicate 'ode_mod' name
44d3e27
@danmm16
Starting CVODE example docs and finishing KINSOL serial example.
9617f18
@danmm16
Merge branch 'develop' of https://github.com/danmm16/sundials-f2003-e…
2e40790 
…xamples into develop
@drreynolds
Fixed merge
55e191b
drreynolds and others added 14 commits June 29, 2023 15:07
@drreynolds
Fixed cv_advdiff_bnd_f2003 example to handle differences in how bande…
e1e1454 
…d matrices are accessed
@drreynolds
debugged ark_diag_non_f2003.f90
8449fd6
@danmm16
Finished two CVODE parallel F2003 examples and updated CMake files so…
37ad288 
… that they run.
@danmm16
Tried to finish the OpenMP example unsuccessfully. All CVODE MPI exam…
0b920c7 
…ples are complete.
@drreynolds
Removed irrelevant OpenMP and Pthreads IDA examples
fe8b86f
@drreynolds
Initial draft of F2003 OpenMP example for IDA
3e38ae2
@danmm16
Tried to fix KINSOL serial F2003 example, edited documentation for ex…
5162587 
…amples of CVODE.
@danmm16
Tried to fix kinDiagon_kry_f2003.f90.
cf86eee
@drreynolds
Fixed so that it only uses right preconditioning
0cc117f
@drreynolds
updates from our discussion
ad18f7f
@drreynolds
Additional updates from our discussion
b5efb6b
@danmm16
Finished ida_heat2D_kry_bbd_f2003.f90 with occasional segmentation fa…
85016f8 
…ult.
@drreynolds
Propagated example guide changes into its own branch
d13a95c
@danmm16
Finished CVODE sans deep dive files.
afc7fb2
balos1
balos1 requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@balos1 balos1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR include documentation that refers to new examples that will come in PR #302?

danmm.lnk Outdated Show resolved Hide resolved
doc/cvode/examples/source/_templates/layout.html Show resolved Hide resolved
@balos1 balos1 added the docs label Jul 25, 2023
@drreynolds
Copy link
Collaborator

I'm closing this PR, since it includes many changes that are not relegated to only doc/cvode. I'll reopen a different PR that includes only the relevant documentation changes.

@drreynolds drreynolds closed this Nov 17, 2023
@drreynolds drreynolds mentioned this pull request Nov 17, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balos1 balos1 balos1 requested changes

@gardner48 gardner48 Awaiting requested review from gardner48 gardner48 is a code owner

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

@drreynolds drreynolds Awaiting requested review from drreynolds drreynolds is a code owner

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danmm16 @drreynolds @balos1