-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapping and tests for PhasedArray3DSpecialCoordinatesImage #232
Conversation
Warnings of style: C:\Dev\ITKUltrasound-22\Wrapping\Modules\Ultrasound\itkPhasedArray3DSpecialCoordinatesImagePython.cpp(5263,54): warning C4834: discarding return value of function with 'nodiscard' attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. @dzenanz can you confirm that Python tests pass locally on your system?
It looks like itk::PhaseArray3DSpecialCoordinatesImage
is implemented in ITK/Core/Common
, could you comment on the decision to add wrapping here in ITKUltrasound? Maybe the wrapping for itk::PhaseArray3DSpecialCoordinatesImage
and general filters could be moved there and then the wrapping for ITKUltrasound spectral analysis filters could be kept here? Though I am not sure whether it is worth the effort or not.
All the tests pass locally, including the ones this PR adds. I also though about adding wrapping to ITK/Core/Common, but:
Moving the wrapping to ITK core should be easy - just move the |
@dzenanz Sounds reasonable to me, thanks for commenting. Good to move forward with changes as-is. |
+1 for migrating this to ITK |
Migrating to ITK via InsightSoftwareConsortium/ITK#4101. |
No description provided.