STYLE: Reorganize wrapping files to ease PA3DSCI migration to ITK core

[dzenanz]

This is a follow-up to #232.

[dzenanz]

Moving PA3DSCI into ITK core produces:

212>------ Build started: Project: itk-stub-files, Configuration: RelWithDebInfo x64 ------
212>Generating .pyi files for Python wrapper interface
212>Traceback (most recent call last):
212>  File "C:\Dev\ITK-git\Wrapping\Generators\Python\itk\pyi_generator.py", line 609, in <module>
212>    class_name = unpack(class_files, options.pyi_dir)
212>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
212>  File "C:\Dev\ITK-git\Wrapping\Generators\Python\itk\pyi_generator.py", line 391, in unpack
212>    base = merge(class_definitions)
212>           ^^^^^^^^^^^^^^^^^^^^^^^^
212>  File "C:\Dev\ITK-git\Wrapping\Generators\Python\itk\pyi_generator.py", line 450, in merge
212>    raise AssertionError(
212>AssertionError: The basic values of two associated classes do not match.
212>Item 1: class `itkImageFileReader::ImageFileReader` has_new_method: `True` typed: `True` is_abstract: `False` is_enum: `False` has_superclass: `False`Item 2: class `itkPhasedArray3DSpecialCoordinatesImageFilters::ImageFileReader` has_new_method: `True` typed: `True` is_abstract: `False` is_enum: `False` has_superclass: `True`
212>C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(248,5): error MSB8066: Custom build for 'C:\Dev\ITK-py11\CMakeFiles\5111c4c6071a90c7f914b45552b82377\itk-stub-files.rule' exited with code 1.
212>Done building project "itk-stub-files.vcxproj" -- FAILED.

which made me change itk_wrap_class("itk::ImageFileReader" POINTER_WITH_SUPERCLASS) into itk_wrap_class("itk::ImageFileReader" POINTER). Should we make the similar changes for other filters in Ultrasound, such as CurvilinearArraySpecialCoordinatesImage, CastImageFilter, RescaleIntensityImageFilter etc?

[tbirdso]

Moving PA3DSCI into ITK core produces: ...
which made me change itk_wrap_class("itk::ImageFileReader" POINTER_WITH_SUPERCLASS) into itk_wrap_class("itk::ImageFileReader" POINTER). Should we make the similar changes for other filters in Ultrasound, such as CurvilinearArraySpecialCoordinatesImage, CastImageFilter, RescaleIntensityImageFilter etc?

@dzenanz Perhaps I'm not understanding what changed if we previously were not seeing compilation issues in ITKUltrasound wrapping. Does the new error occur in ITKUltrasound or in ITK? Could you point to your ITK branch or draft PR where those changes are taking place?

[dzenanz]

I just pushed my current state to my fork's master. This includes the change to avoid the above error.

[dzenanz]

I think the reason for not seeing this error earlier, is that now both of those wrappings are part of the same translation unit (or better to say, wrapping unit).

[dzenanz]

So maybe these differences don't matter, unless both definitions are part of the same "wrapping unit". It would be quite a bit of effort to harmonize them all, and if we miss some we would not get any warnings. So my question is: does it matter? @thewtex could pitch in too.

[tbirdso]

I think the reason for not seeing this error earlier, is that now both of those wrappings are part of the same translation unit (or better to say, wrapping unit).

Ah, good point. Yes, in general I agree that the wrapping specification (POINTER, POINTER_WITH_SUPERCLASS, etc) in ITKUltrasound should match the base class in ITK.

EDIT: I am not fully aware of what impact there might be from a mismatch in each specification between ITKUltrasound and ITK.

[dzenanz]

I just created a draft PR InsightSoftwareConsortium/ITK#4099. We should split the discussion between this PR and that one, as appropriate.

[dzenanz]

Closed in favor of #234.