-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python wrapping for PhasedArray3DSpecialCoordinatesImage #4101
Add Python wrapping for PhasedArray3DSpecialCoordinatesImage #4101
Conversation
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@thewtex Would you please comment on when you expect a v5.4rc01 release to be packaged to include these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzenanz awesome!!
Could you please check a build of ITKPythonPackage, adjusting the repository and hash here:
before merging to ensure that there are not any build errors or wrapping warnings. The package has other wrapping options enabled, and this is a good check for the type combinations enabled here.
@tbirdso ITK 5.4rc01 has been tagged, I am resolving a few wrapping issues. This will be included in 5.3rc02.
Following the Windows section of wheel building instructions, I invoked building via As far as I can tell, these changes did not introduce new errors or warnings. As even the first build did not finish without errors, I am not absolutely certain. Taking a closer look at the logs, there are reassuring entries related to phased array, the last one of which is:
Full build logs: I think we can merge this. |
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101
I am building once more locally, I will merge if all goes well. |
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101 Closes KitwareMedical#234.
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101 Closes KitwareMedical#234.
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101 Closes KitwareMedical#234.
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101 Closes KitwareMedical#234.
This is essentially a migration of KitwareMedical/ITKUltrasound#232 from Ultrasound remote module to here. It involved some non-trivial reorganization. It is also a prettified version of #4099.
PR Checklist