Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KomaMRI v0.7.4: Bug fixes and minor features #163

Merged
merged 142 commits into from
Jul 12, 2023
Merged

KomaMRI v0.7.4: Bug fixes and minor features #163

merged 142 commits into from
Jul 12, 2023

Conversation

cncastillo
Copy link
Member

@cncastillo cncastillo commented Apr 26, 2023

In this pull request I have changed some parts of the simulation method to be able to sample the magnetization in an RF Bloch. Also, I fixed bugs #161 #162 #85 #88 by modifying the TimeStepCalculation.jl get_variable_times. Finally, I added some extra features, as now you can plot the eddy currents and the MC2 of a sequence, and a new BlochDict method that showcases how you can generate custom outputs and create new simulation methods without the need of modifying the source code of KomaMRICore.

KomaMRI -> 0.7.4
KomaCore -> 0.7.5
KomaPlots -> 0.7.5

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Merging #163 (721f053) into master (18491fb) will increase coverage by 43.54%.
The diff coverage is 94.98%.

❗ Current head 721f053 differs from pull request most recent head 4a8212f. Consider uploading reports for the commit 4a8212f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #163       +/-   ##
===========================================
+ Coverage   48.91%   92.45%   +43.54%     
===========================================
  Files          35       39        +4     
  Lines        2067     2135       +68     
===========================================
+ Hits         1011     1974      +963     
+ Misses       1056      161      -895     
Flag Coverage Δ
core 91.53% <92.02%> (+37.67%) ⬆️
komamri 93.84% <98.10%> (+92.95%) ⬆️
plots 95.00% <93.33%> (+35.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
KomaMRICore/src/datatypes/sequence/Delay.jl 100.00% <ø> (+100.00%) ⬆️
KomaMRICore/src/simulation/other/DiffusionModel.jl 100.00% <ø> (+90.90%) ⬆️
KomaMRIPlots/src/KomaMRIPlots.jl 100.00% <ø> (ø)
src/KomaMRI.jl 100.00% <ø> (ø)
src/ui/PulsesGUI_M0.jl 100.00% <ø> (+100.00%) ⬆️
src/ui/PulsesGUI_kspace.jl 100.00% <ø> (+100.00%) ⬆️
src/ui/PulsesGUI_seq.jl 100.00% <ø> (+100.00%) ⬆️
.../src/simulation/Bloch/BlochDictSimulationMethod.jl 90.32% <50.00%> (+90.32%) ⬆️
KomaMRICore/src/datatypes/sequence/Grad.jl 94.82% <66.66%> (+36.64%) ⬆️
KomaMRICore/src/datatypes/sequence/RF.jl 88.67% <66.66%> (+18.67%) ⬆️
... and 18 more

... and 5 files with indirect coverage changes

@cncastillo cncastillo merged commit 36a9d19 into master Jul 12, 2023
@cncastillo cncastillo deleted the koma_v074 branch July 26, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants