Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with ADC next to RF object #161

Closed
cncastillo opened this issue Mar 22, 2023 · 0 comments · Fixed by #163
Closed

Problem with ADC next to RF object #161

cncastillo opened this issue Mar 22, 2023 · 0 comments · Fixed by #163
Labels
1) high priority bug Something isn't working

Comments

@cncastillo
Copy link
Member

Sometimes when an ADC is beside an RF object the RF object is not simulated. Minimal working example:

seq = Sequence()
seq += RF(B1,T)
seq += ADC(N, T)
seq += RF(B1,T)

The problem does not appear when N=1 as the function get_adc_sampling_times interprets that cases differently. A solution would be to sample the ADC from $0 + \epsilon$ to $T -\epsilon$, with $\epsilon$ a very small number, so it can never happen that the start/end of an RF coincides with an ADC sampling point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1) high priority bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant