Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added env for cilium #97

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions cilium/0.0.1/besman-cilium-RT-env-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
BESMAN_ORG: Be-Secure
BESMAN_ARTIFACT_TYPE: project
BESMAN_ARTIFACT_NAME: cilium
BESMAN_ARTIFACT_VERSION: 0.0.1
BESMAN_ARTIFACT_URL: https://github.com/Be-Secure/kubernetes
BESMAN_ENV_NAME: cilium-RT-env
BESMAN_ARTIFACT_DIR: $HOME/CRS_Work/temp/$BESMAN_ARTIFACT_NAME
BESMAN_TOOL_PATH: /opt
BESMAN_LAB_TYPE: Organization
BESMAN_LAB_NAME: Be-Secure
BESMAN_ASSESSMENT_DATASTORE_DIR: $HOME/CRS_Work/temp/besecure-assessment-datastore
BESMAN_ASSESSMENT_DATASTORE_URL: https://github.com/Be-Secure/besecure-assessment-datastore
BESMAN_REQUIRED_TOOL_SET:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samirparhi-dev , this kind of yaml structure is not supported by BeSman. @asa1997 was using cut command internally to fetch the besman env variables and values. As per the logic BESMAN_REQUIRED_TOOL_SET is empty, and BeSman will throw error if any env variable is empty at the time of running the script. BESMAN_REQUIRED_TOOL_SET and BESMAN_REQUIRED_TOOL_SET must have some values.

ex:

BESMAN_REQUIRED_TOOL_SET: <values>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samirparhi-dev , this kind of yaml structure is not supported by BeSman. @asa1997 was using cut command internally to fetch the besman env variables and values. As per the logic BESMAN_REQUIRED_TOOL_SET is empty, and BeSman will throw error if any env variable is empty at the time of running the script. BESMAN_REQUIRED_TOOL_SET and BESMAN_REQUIRED_TOOL_SET must have some values.

ex:

BESMAN_REQUIRED_TOOL_SET: <values>

@pramit-d: My whole logic consider the configfile as .yml and I used .yml parser . .yml should be treated like yml not .txt right ?

@harimohanr @panickervinod @asa1997 May I know why the design is way?

yq:
version: "latest"
type: "Default"
port_fwd: ""
port: ""
codeql:
port: 8080
version: "latest"
port_fwd: ""
type: "Default"
scorecard:
port: 8080
version: "latest"
port_fwd: ""
type: "Default"
sonar:
port: 9000
port_fwd: "9000"
version: "latest"
type: "container"
snyk:
port: 8080
port_fwd: ""
version: "latest"
type: "Default"
python3:
port: ""
port_fwd: ""
version: "latest"
type: "Default"
pip:
port: ""
port_fwd: ""
version: "latest"
type: "Default"
go:
port: ""
port_fwd: ""
version: "latest"
type: "Default"
podman:
port: 8080
port_fwd: ""
version: "latest"
type: "Default"
fosology:
port: 8080
port_fwd: "8080"
version: "latest"
type: "container"
BESMAN_SYSTEM_CURRENT_STATE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samirparhi-dev , BESMAN_SYSTEM_CURRENT_STATE should not be empty, otherwise BeSman will throw error.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samirparhi-dev , BESMAN_SYSTEM_CURRENT_STATE should not be empty, otherwise BeSman will throw error.

@pramit-d: My whole logic consider the configfile as .yml and I used .yml parser . .yml should be treated like yml not .txt right ?

@harimohanr @panickervinod @asa1997 May I know why the design is way?

Loading