-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added env for cilium #97
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: samirparhi-dev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @samirparhi-dev, please update environment-metadata.json and list.txt files. Without updating list.txt, the env will not be available in the env list.
Signed-off-by: samirparhi-dev <[email protected]>
Signed-off-by: samirparhi-dev <[email protected]>
Signed-off-by: samirparhi-dev <[email protected]>
@pramit-d :done |
BESMAN_LAB_NAME: Be-Secure | ||
BESMAN_ASSESSMENT_DATASTORE_DIR: $HOME/CRS_Work/temp/besecure-assessment-datastore | ||
BESMAN_ASSESSMENT_DATASTORE_URL: https://github.com/Be-Secure/besecure-assessment-datastore | ||
BESMAN_REQUIRED_TOOL_SET: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samirparhi-dev , this kind of yaml structure is not supported by BeSman. @asa1997 was using cut command internally to fetch the besman env variables and values. As per the logic BESMAN_REQUIRED_TOOL_SET is empty, and BeSman will throw error if any env variable is empty at the time of running the script. BESMAN_REQUIRED_TOOL_SET and BESMAN_REQUIRED_TOOL_SET must have some values.
ex:
BESMAN_REQUIRED_TOOL_SET: <values>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samirparhi-dev , this kind of yaml structure is not supported by BeSman. @asa1997 was using cut command internally to fetch the besman env variables and values. As per the logic BESMAN_REQUIRED_TOOL_SET is empty, and BeSman will throw error if any env variable is empty at the time of running the script. BESMAN_REQUIRED_TOOL_SET and BESMAN_REQUIRED_TOOL_SET must have some values.
ex:
BESMAN_REQUIRED_TOOL_SET: <values>
@pramit-d: My whole logic consider the configfile as .yml
and I used .yml
parser . .yml
should be treated like yml
not .txt
right ?
@harimohanr @panickervinod @asa1997 May I know why the design is way?
port_fwd: "8080" | ||
version: "latest" | ||
type: "container" | ||
BESMAN_SYSTEM_CURRENT_STATE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samirparhi-dev , BESMAN_SYSTEM_CURRENT_STATE should not be empty, otherwise BeSman will throw error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samirparhi-dev , BESMAN_SYSTEM_CURRENT_STATE should not be empty, otherwise BeSman will throw error.
@pramit-d: My whole logic consider the configfile as .yml
and I used .yml
parser . .yml
should be treated like yml
not .txt
right ?
@harimohanr @panickervinod @asa1997 May I know why the design is way?
Signed-off-by: samirparhi-dev <[email protected]>
As per the Discussion with Arun, Currently I have bypassed the Variable name and commited. We will later enhance the besman tool to handle is automatically . @pramit-d: Do test and let me know if all are working or anything breaking FYI @bananth2008 |
FYI @panickervinod @harimohanr @sumodgeorge @asa1997