Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selenium test to support system-app #3210

Closed
wants to merge 1 commit into from

Conversation

saschanaz
Copy link
Contributor

For now I did this, but can we use something like this: https://developer.chrome.com/docs/extensions/reference/manifest/key#keep-consistent-id ?

@saschanaz saschanaz marked this pull request as ready for review December 28, 2023 11:52
@dstillman
Copy link
Member

Can you explain what this is for?

@saschanaz
Copy link
Contributor Author

It's to fix the CI failure: #3209 (comment)

@AbeJellinek
Copy link
Member

Thanks so much for the pointer to that manifest.json key. We've updated the Connector and I just updated the script here to use the constant ID (6b4a4dc) - should do the trick!

@saschanaz
Copy link
Contributor Author

It seems that didn't work: https://github.com/zotero/translators/actions/runs/7469963343/job/20327889161

Are you sure the extension ID is guaranteed to be constant?

@saschanaz
Copy link
Contributor Author

Hmm, actually that failure happens earlier than getting the URL, hmm.

@aborel
Copy link
Contributor

aborel commented Jan 15, 2024

In https://github.com/zotero/translators/actions/runs/7469963343/job/20327889161 it seems that translatorServer.filenameToTranslator[translatorFilename] is undefined (for some value of translatorFilename). The lint test in the same log is run on TinREAD.js. Based on the comments in #3223 (commits) , maybe the file should not even be there at all?
When I try to run these updated tests locally on my pending InvenioRDM translators, things look OK.

@saschanaz
Copy link
Contributor Author

saschanaz commented Jan 16, 2024

Per https://github.com/zotero/translators/actions/runs/7540520982/job/20525278512 no, they all look proper files with metadata. (I added console.log("translators to check:", translatorFilenames);)

@saschanaz
Copy link
Contributor Author

Submitted #3231.

@saschanaz
Copy link
Contributor Author

Alright, #3213 is green now, I'll close this one. Thanks!

@saschanaz saschanaz closed this Jan 17, 2024
@saschanaz saschanaz deleted the chrome-shadow branch January 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants