Skip to content

Commit

Permalink
CI: Use constant extension ID
Browse files Browse the repository at this point in the history
  • Loading branch information
AbeJellinek committed Jan 10, 2024
1 parent d24b779 commit 6b4a4dc
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions .ci/pull-request-check/selenium-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const translatorServer = require('./translator-server');

const chromeExtensionDir = path.join(__dirname, 'connectors', 'build', 'chrome');
const KEEP_BROWSER_OPEN = 'KEEP_BROWSER_OPEN' in process.env;
const ZOTERO_CONNECTOR_EXTENSION_ID = 'ekhagklcjbdpajgpjgmbionohlpdbjgc';

async function getTranslatorsToTest() {
const translatorFilenames = process.argv[2].split('\n').filter(filename => filename.trim().length > 0);
Expand Down Expand Up @@ -111,21 +112,9 @@ var allPassed = false;
.setChromeOptions(options)
.build();

// No API to retrieve extension ID. Hacks, sigh.
await driver.get("chrome://system/");
await driver.wait(until.elementLocated({id: 'btn-extensions-value'}), 60*1000);
// Chrome 89+ has the extension list expanded by default
try {
let extBtn = await driver.findElement({css: '#btn-extensions-value'});
await extBtn.click();
} catch (e) {}
let contentElem = await driver.findElement({css: '#content'});
let text = await contentElem.getText();
let extId = text.match(/([^\s]*) : Zotero Connector/)[1];

// We got the extension ID and test URL, let's test
// We got the test URL, let's test
const translatorsToTest = await getTranslatorsToTest();
let testUrl = `chrome-extension://${extId}/tools/testTranslators/testTranslators.html#translators=${translatorsToTest.join(',')}`;
let testUrl = `chrome-extension://${ZOTERO_CONNECTOR_EXTENSION_ID}/tools/testTranslators/testTranslators.html#translators=${translatorsToTest.join(',')}`;
await new Promise((resolve) => setTimeout(() => resolve(driver.get(testUrl)), 500));
await driver.wait(until.elementLocated({id: 'translator-tests-complete'}), 30*60*1000);
testResults = await driver.executeScript('return window.seleniumOutput');
Expand Down

0 comments on commit 6b4a4dc

Please sign in to comment.