Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wetten.overheid.nl #3209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CaspervanWetten
Copy link

Added translator for Wetten.overheid.nl, the website where all Dutch laws are published

@CaspervanWetten
Copy link
Author

I don't quite understand why the check fails. The log mentions a timeout error waiting for the location of element [id="btn-extensive-value"], but the translator never looks for this button?

@adam3smith
Copy link
Collaborator

That's a Chrome button that's failing in the Selenium tests; nothing to do with your code (see here for the last time this was fixed: #3003 ).

I haven't done a thorough review, but we'd want a) multiples included and b) new translators to use async calls (i.e. requestText or requestDocument instead of doGet

@CaspervanWetten
Copy link
Author

What do you mean with "multiples included"?
Do you have any examples of new translators that use async calls I can look at?

@aborel
Copy link
Contributor

aborel commented Dec 22, 2023

The translator should support importing multiple references, typically from search results on the platform, not just one reference from its own web page.
The Cairn.info translator https://github.com/zotero/translators/blob/master/Cairn.info.js looks fairly simple, it contains a requestText() call, and it has been recently updated by an experienced developer. I guess it is a good example to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants