Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: fix bad filtering, file naming in 2 samples #77818

Merged
merged 2 commits into from
Sep 4, 2024
Merged

samples: fix bad filtering, file naming in 2 samples #77818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1adebc8
sample: sip_svc: fix filter and printk formatting
nashif Aug 30, 2024
0a9a122
sample: uart passthrough: fix filtering and twister file
nashif Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions samples/drivers/uart/passthrough/sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
sample:
name: UART Passthrough
tests:
sample.drivers.uart.passthrough:
platform_allow:
- nucleo_l476rg
tags:
- serial
- uart
harness: keyboard
14 changes: 0 additions & 14 deletions samples/drivers/uart/passthrough/sample.yml
View file
Open in desktop

This file was deleted.

10 changes: 6 additions & 4 deletions samples/subsys/sip_svc/sample.yml → samples/subsys/sip_svc/sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@ common:
- intel_socfpga_agilex_socdk
tests:
sample.subsys.sip_svc:
tags: subsys
tags:
- sipsvc
platform_allow:
- intel_socfpga_agilex_socdk
integration_platforms:
- intel_socfpga_agilex_socdk
harness: console
harness_config:
type: one_line
ordered: true
regex:
- "Got response of transaction id 0x[0-9a-f][0-9a-f] and voltage is [0-9].[0-9]+v"
filter: CONFIG_ARM_SIP_SVC_HAS_INTEL_SDM_MAILBOX_FIFO
integration_platforms:
- intel_socfpga_agilex_socdk
4 changes: 2 additions & 2 deletions samples/subsys/sip_svc/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@
/* Voltage is retrieved as a fixed point number with 16 bits below binary point */
voltage = ((float)priv.voltage_channel0 / 65536);

printk("Got response of transaction id 0x%02x and voltage is %fv\n", trans_id,
voltage);
printk("Got response of transaction id 0x%02x and voltage is %fv\n",
trans_id, (double)voltage);

Check notice on line 109 in samples/subsys/sip_svc/src/main.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

samples/subsys/sip_svc/src/main.c:109 
-		printk("Got response of transaction id 0x%02x and voltage is %fv\n",
-			trans_id, (double)voltage);
+		printk("Got response of transaction id 0x%02x and voltage is %fv\n", trans_id,
+		       (double)voltage);
err = sip_svc_close(mb_smc_ctrl, mb_c_token, NULL);
__ASSERT(err != SIP_SVC_ID_INVALID, "Failed to close with sip_svc");

Expand Down
Loading