samples: fix bad filtering, file naming in 2 samples #77818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nashif
commented
Aug 30, 2024
nashif
commented
- sample: sip_svc: fix filter and printk formatting
- sample: uart passthrough: fix filtering and twister file
Rename sample.yml and fix build and filtering. Signed-off-by: Anas Nashif <[email protected]>
nashif
added
the
Trivial
zephyrbot
added
area: Samples
kartben
previously approved these changes
Aug 30, 2024
dcpleung
previously approved these changes
Aug 30, 2024
sample.yml is wrong and was not scanned. Also fix filters in the file so it can build. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/samples/fixes_1
branch
from
b615be5
to
0a9a122
Compare
dcpleung
approved these changes
Sep 3, 2024
kartben
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.