-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Controller: Separate SDU interval for C_to_P and P_to_C #76453
Merged
carlescufi
merged 2 commits into
zephyrproject-rtos:main
from
cvinayak:github_iso_interval_sdu_interval_calc
Aug 5, 2024
Merged
Bluetooth: Controller: Separate SDU interval for C_to_P and P_to_C #76453
carlescufi
merged 2 commits into
zephyrproject-rtos:main
from
cvinayak:github_iso_interval_sdu_interval_calc
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for separate SDU interval for C_to_P and P_to_C directions when setting CIG parameters. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_iso_interval_sdu_interval_calc
branch
from
July 30, 2024 08:05
ca4c50a
to
0889fec
Compare
zephyrbot
requested review from
carlescufi,
erbr-ot,
kruithofa,
mtpr-ot,
thoh-ot and
wopu-ot
July 30, 2024 10:02
Thalley
requested changes
Aug 2, 2024
Comment on lines
240
to
241
/* Check if this is a HAP usecase which requires higher link bandwidth to ensure | ||
* segmentation is not invoked in ISO-AL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but how can the controller determine which LE Audio profile is being used? :s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, @wopu-ot ?
Review rework related to separate SDU interval for C_to_P and P_to_C support. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Thalley
approved these changes
Aug 2, 2024
kruithofa
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for separate SDU interval for C_to_P and P_to_C directions when setting CIG parameters.
Relates to #64186 and may fix #74495 bsim failure.
Fixes #74544.