Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: BAP: Support setting different values per dir in CIG #74495

Merged

Conversation

Thalley
Copy link
Collaborator

@Thalley Thalley commented Jun 18, 2024

The interval and latency for a CIG are set for each direction now, allowing applications to use e.g. 10ms for sink ASEs and 7.5ms for source ASEs.

fixes #64186

@Thalley Thalley force-pushed the unicast_group_interval_update branch 2 times, most recently from fdd037d to 3af02e3 Compare June 19, 2024 12:55
@Thalley Thalley force-pushed the unicast_group_interval_update branch 2 times, most recently from 5cda2b2 to 1c84b5d Compare June 21, 2024 11:27
@Thalley Thalley marked this pull request as ready for review June 21, 2024 11:29
@Thalley
Copy link
Collaborator Author

Thalley commented Jun 21, 2024

CI will fail until #74544 is fixed or the test is disabled.

@Thalley Thalley force-pushed the unicast_group_interval_update branch from c651cba to 92bc1ae Compare June 25, 2024 09:15
kruithofa
kruithofa previously approved these changes Jun 26, 2024
@Thalley
Copy link
Collaborator Author

Thalley commented Jun 27, 2024

Updated the documentation

@Thalley Thalley requested a review from kruithofa June 27, 2024 15:15
The interval and latency for a CIG are set for each direction now,
allowing applications to use e.g. 10ms for sink ASEs and 7.5ms for
source ASEs.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley Thalley force-pushed the unicast_group_interval_update branch from 3f5f044 to 3861fa4 Compare July 1, 2024 08:32
@Thalley
Copy link
Collaborator Author

Thalley commented Aug 13, 2024

@carlescufi Why was this closed?

This PR is implementing a feature in the host and #76453 is fixing something in the controller.

@Thalley Thalley reopened this Aug 13, 2024
@aescolar
Copy link
Member

@carlescufi Why was this closed?

This PR is implementing a feature in the host and #76453 is fixing something in the controller.

carlescufi closed this in #76453

Probably because Github is not that smart :), and writing "fixes #*" causes that something to be closed even if it is another PR

@aescolar aescolar merged commit ba62c8d into zephyrproject-rtos:main Aug 14, 2024
50 of 51 checks passed
@Thalley Thalley deleted the unicast_group_interval_update branch August 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bluetooth: BAP: allow separate values for Central-to-Peer and Peer-to-Central parameters from QOS
5 participants