boards: shields: add suport for st_b_cams_omv_mb1683 #76143
+234
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2024
CharlesDias
force-pushed
the
st_b_cams_omv_mb1683
branch
2 times, most recently
from
4377923
to
74f10a5
Compare
erwango
reviewed
Jul 30, 2024
Comment on lines
98
to
105
| ``_st_b_cams_omv_mb1683`` and adding the necessary device tree properties. | ||
|
|
||
| Set ``--shield "_st_b_cams_omv_mb1683"`` when you invoke ``west build``. For example: | ||
|
|
||
| .. zephyr-app-commands:: | ||
| :zephyr-app: samples/subsys/video/capture | ||
| :board: stm32h7b3i_dk | ||
| :shield: _st_b_cams_omv_mb1683 |
There was a problem hiding this comment.
Why using the prefix _ in _st_b_cams_omv_mb1683 ?
There was a problem hiding this comment.
Fixed. It was a copy past problem! :-)
Thanks for your review! Let me know if you have any other suggestion.
There was a problem hiding this comment.
For now PR was in draft, so I didn't go much further in the review.If not draft anymore, just move PR to ready for review.
There was a problem hiding this comment.
I'm wanting to this #76124 going to upstream before change it to review.
CharlesDias
force-pushed
the
st_b_cams_omv_mb1683
branch
from
74f10a5
to
f9b29d6
Compare
CharlesDias
changed the title
Add support for ST B-CAMS-OMV MB1683 shield. Signed-off-by: Charles Dias <[email protected]>
CharlesDias
force-pushed
the
st_b_cams_omv_mb1683
branch
from
f9b29d6
to
de6b1c4
Compare
CharlesDias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ST B-CAMS-OMV MB1683 shield.
Required PR: