RISCV: fix PMP stack guard not active during boot #75622
Merged
+51
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2024 17:08
This will be needed at more than one location. Signed-off-by: Nicolas Pitre <[email protected]>
Before this, stack protection would be effective only after switching to the first thread. Even before the first thread is created, the kernel init code uses the IRQ stack to set things up. Let's make sure this is safeguarded as well. This also fixes the incompatibility between CONFIG_RISCV_PMP and CONFIG_RISCV_ALWAYS_SWITCH_THROUGH_ECALL, the later needing an exception call to switch to the first thread and exception code assuming stack guard is already set up in the PMP. Signed-off-by: Nicolas Pitre <[email protected]>
zephyrbot
requested review from
carlocaione,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
mgielda,
tgorochowik and
ycsin
This was referenced Jul 8, 2024
Merged
jimmyzhe
approved these changes
Jul 10, 2024
fkokosinski
approved these changes
Jul 11, 2024
edersondisouza
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, stack protection would be effective only after switching to
the first thread.
Even before the first thread is created, the kernel init code uses the
IRQ stack to set things up. Let's make sure this is safeguarded as well.
This also fixes the incompatibility between
CONFIG_RISCV_PMPandCONFIG_RISCV_ALWAYS_SWITCH_THROUGH_ECALL, the later needing an exceptioncall to switch to the first thread and exception code assuming stack
guard is already set up in the PMP.