driver: interrupt_controller: nuclei_eclic: fixed interrupt level and CLIC enable #75580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLIC should be the first level interrupt controller because it replaces the basic RISC-V local interrupt. The interrupt level in CLIC controls preemption between IRQs, rather than specifying the number of nested interrupt controllers. Removed CONFIG_MULTI_LEVEL_INTERRUPTS and the incorrect interrupt level. Signed-off-by: Jimmy Zheng <[email protected]>
RISC-V trap entry is handled in soc/common/riscv-privileged/vector.S. Remove the redundant modification in CLIC driver. Signed-off-by: Jimmy Zheng <[email protected]>
soburi
approved these changes
Jul 11, 2024
cameled
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Refer ECLIC and PLIC Connection Diagram. Looks currently Nuclei ECLIC not support multi-level (nested) interrupt controller arrangement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the Nuclei CLIC driver:
Incorrect CLIC interrupt level configuration:
The CLIC interrupt level controls preemption between IRQs, while multi-level interrupts in Zephyr are for nested controllers. Removed the incorrect setting of the CLIC interrupt level.
Redundant CLIC mode enable:
The RISC-V CLIC enable is already handled in vector.S in the RISC-V common code. Removed the redundant CLIC mode enable.