Bluetooth: ISO: Tone down some dbg logs #75430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several log statements were using the regualar LOG_DBG, but when ISO is actually used, those were called every TX which at 10ms SDU intervals would fill up the log really fast and not provided much value outside of some specific debugging. Modified those logs to use BT_ISO_DATA_DBG which is another log level for ISO data. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
added
the
Trivial
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
jori-nordic,
sjanc and
theob-pro
jori-nordic
approved these changes
Jul 4, 2024
Noticed this during a BAP BSIM test and it's a non-issue there with in terms of CPU, but the 20.000 or so log lines didn't help debugging the failing test :D |
aasinclair
approved these changes
Jul 5, 2024
alwa-nordic
approved these changes
Jul 5, 2024
jhedberg
approved these changes
Jul 5, 2024
kruithofa
approved these changes
Jul 5, 2024
aescolar
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several log statements were using the regualar LOG_DBG, but when ISO is actually used, those were called every TX which at 10ms SDU intervals would fill up the log really fast and not provided much value outside of some specific debugging.
Modified those logs to use BT_ISO_DATA_DBG which is another log level for ISO data.