Skip to content

Commit

Permalink
Bluetooth: ISO: Tone down some dbg logs
Browse files Browse the repository at this point in the history
Several log statements were using the regualar LOG_DBG,
but when ISO is actually used, those were called every TX
which at 10ms SDU intervals would fill up the log really fast
and not provided much value outside of some specific debugging.

Modified those logs to use BT_ISO_DATA_DBG which is another
log level for ISO data.

Signed-off-by: Emil Gydesen <[email protected]>
  • Loading branch information
Thalley authored and aescolar committed Jul 5, 2024
1 parent 2e1c04a commit 19fe067
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions subsys/bluetooth/host/iso.c
Original file line number Diff line number Diff line change
Expand Up @@ -757,15 +757,15 @@ static struct net_buf *iso_data_pull(struct bt_conn *conn,
size_t *length)
{
#if defined(CONFIG_BT_ISO_TX)
LOG_DBG("conn %p amount %d", conn, amount);
BT_ISO_DATA_DBG("conn %p amount %d", conn, amount);

/* Leave the PDU buffer in the queue until we have sent all its
* fragments.
*/
struct net_buf *frag = k_fifo_peek_head(&conn->iso.txq);

if (!frag) {
LOG_DBG("signaled ready but no frag available");
BT_ISO_DATA_DBG("signaled ready but no frag available");
/* Service other connections */
bt_tx_irq_raise();

Expand Down Expand Up @@ -797,7 +797,7 @@ static struct net_buf *iso_data_pull(struct bt_conn *conn,
if (last_frag) {
__maybe_unused struct net_buf *b = k_fifo_get(&conn->iso.txq, K_NO_WAIT);

LOG_DBG("last frag, pop buf");
BT_ISO_DATA_DBG("last frag, pop buf");
__ASSERT_NO_MSG(b == frag);
}

Expand Down Expand Up @@ -846,7 +846,7 @@ int conn_iso_send(struct bt_conn *conn, struct net_buf *buf, enum bt_iso_timesta
net_buf_push_u8(buf, has_ts);

net_buf_put(&conn->iso.txq, buf);
LOG_DBG("%p put on list", buf);
BT_ISO_DATA_DBG("%p put on list", buf);

/* only one ISO channel per conn-object */
bt_conn_data_ready(conn);
Expand Down Expand Up @@ -914,7 +914,7 @@ int bt_iso_chan_send(struct bt_iso_chan *chan, struct net_buf *buf, uint16_t seq

iso_conn = chan->iso;

LOG_DBG("send-iso (no ts)");
BT_ISO_DATA_DBG("send-iso (no ts)");
return conn_iso_send(iso_conn, buf, BT_ISO_TS_ABSENT);
}

Expand Down

0 comments on commit 19fe067

Please sign in to comment.