Bluetooth: Deprecate adv auto-resume #73395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asbjornsabo,
hermabe,
jhedberg,
jori-nordic,
sjanc,
Thalley,
theob-pro and
Vudentz
alwa-nordic
force-pushed
the
rm-adv-resume/add-wrn
branch
from
7d1b3e0
to
68ea33a
Compare
|
Last push fixes compliance check:
|
Thalley
reviewed
May 28, 2024
Thalley
reviewed
May 28, 2024
|
Latest push removes the adv/resume2 test, which was failing this PR because of the deprecation warning. |
alwa-nordic
added
the
Bluetooth Review
jori-nordic
previously approved these changes
May 29, 2024
carlescufi
reviewed
May 30, 2024
carlescufi
previously requested changes
May 30, 2024
Thalley
reviewed
Jun 3, 2024
alwa-nordic
force-pushed
the
rm-adv-resume/add-wrn
branch
from
9bb9ed8
to
bc2aa3a
Compare
alwa-nordic
force-pushed
the
rm-adv-resume/add-wrn
branch
from
2f8795b
to
1bfdbfd
Compare
jhedberg
previously approved these changes
Aug 28, 2024
Thalley
previously approved these changes
Aug 28, 2024
ubieda
previously approved these changes
Aug 28, 2024
theob-pro
previously approved these changes
Sep 3, 2024
|
Added the DNM flag for now, until we have a consensus on how to proceed with #77775 since that may have an impact on this API. |
|
@jhedberg isn't it kind of moot if the API in question is being removed? We are determined to remove auto-resume. |
You're probably right. I just wanted to pull the handbrake a little, in case it would have emerged from the discussion in the other PR that we actually don't want to deprecate/remove this feature. |
alwa-nordic
dismissed stale reviews from theob-pro, ubieda, Thalley, and jhedberg
via
c9c11e7
alwa-nordic
force-pushed
the
rm-adv-resume/add-wrn
branch
from
3b06937
to
c9c11e7
Compare
|
Pushed rebase. No conflicts. |
Thalley
previously approved these changes
Sep 13, 2024
jori-nordic
previously approved these changes
Sep 13, 2024
alwa-nordic
dismissed stale reviews from jori-nordic and Thalley
via
efd8422
alwa-nordic
force-pushed
the
rm-adv-resume/add-wrn
branch
2 times, most recently
from
efd8422
to
846f1f6
Compare
Thalley
reviewed
Sep 13, 2024
alwa-nordic
force-pushed
the
rm-adv-resume/add-wrn
branch
from
846f1f6
to
a8428a1
Compare
alwa-nordic
force-pushed
the
rm-adv-resume/add-wrn
branch
4 times, most recently
from
28337fd
to
1fa9f59
Compare
The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>
alwa-nordic
force-pushed
the
rm-adv-resume/add-wrn
branch
from
1fa9f59
to
8c31990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details.
This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like
conn_cb.recycled, which has obvious behavior that is unlikely to change.Resolves: #72567