Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Tester: Adjust bap ext adv options #73361

Conversation

Frodevan
Copy link
Contributor

This change removes the BT_LE_PER_ADV_OPT_USE_TX_POWER option for extended advertisement in BLE Audio PTS tests.

The Broadcaster setup options was hardcoded to include the BT_LE_PER_ADV_OPT_USE_TX_POWER option. This causes incompabilities for any controller not support it, and since the option is not required for the audio tests it should not be used here.

This change removes the BT_LE_PER_ADV_OPT_USE_TX_POWER option for
extended advertisement in BLE Audio PTS tests.

The Broadcaster setup options was hardcoded to include the
BT_LE_PER_ADV_OPT_USE_TX_POWER option. This causes incompabilities
for any controller not support it, and since the option is not
required for the audio tests it should not be used here.

signed-off-by: Frode van der Meeren <[email protected]>
Copy link
Contributor

@cvinayak cvinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... will wait on review from @mkasenberg or @sjanc

@Frodevan
Copy link
Contributor Author

Frodevan commented Jun 5, 2024

@jhedberg Any updates on this?

@jhedberg jhedberg assigned Thalley and unassigned jhedberg Jun 5, 2024
@jhedberg
Copy link
Member

jhedberg commented Jun 5, 2024

@jhedberg Any updates on this?

I had ignored it since it's audio related. Re-assigned to @Thalley now, so the merge criteria are satisfied.

@jhedberg jhedberg merged commit e414acf into zephyrproject-rtos:main Jun 5, 2024
20 checks passed
Frodevan added a commit to Frodevan/sdk-zephyr that referenced this pull request Jul 9, 2024
This change removes the BT_LE_PER_ADV_OPT_USE_TX_POWER option for
extended advertisement in BLE Audio PTS tests.

The Broadcaster setup options was hardcoded to include the
BT_LE_PER_ADV_OPT_USE_TX_POWER option. This causes incompabilities
for any controller not support it, and since the option is not
required for the audio tests it should not be used here.

Upstream PR: zephyrproject-rtos/zephyr#73361

signed-off-by: Frode van der Meeren <[email protected]>
anangl pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Jul 9, 2024
This change removes the BT_LE_PER_ADV_OPT_USE_TX_POWER option for
extended advertisement in BLE Audio PTS tests.

The Broadcaster setup options was hardcoded to include the
BT_LE_PER_ADV_OPT_USE_TX_POWER option. This causes incompabilities
for any controller not support it, and since the option is not
required for the audio tests it should not be used here.

Upstream PR: zephyrproject-rtos/zephyr#73361

signed-off-by: Frode van der Meeren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants