[nrf fromlist] bluetooth: tester: Adjust Broadcaster ext adv pars #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should be done upstream. We do not need |
Frodevan
force-pushed
the
bt-tester-broadcast-adv-parameters
branch
from
676131e
to
98e6b70
Compare
Frodevan
force-pushed
the
bt-tester-broadcast-adv-parameters
branch
2 times, most recently
from
a2a5970
to
2223e5b
Compare
Frodevan
force-pushed
the
bt-tester-broadcast-adv-parameters
branch
from
2223e5b
to
72efff5
Compare
Thalley
approved these changes
Jun 21, 2024
Frodevan
force-pushed
the
bt-tester-broadcast-adv-parameters
branch
from
72efff5
to
3a1ad71
Compare
Frodevan
changed the title
Frodevan
force-pushed
the
bt-tester-broadcast-adv-parameters
branch
from
3a1ad71
to
8bfda4b
Compare
Frodevan
force-pushed
the
bt-tester-broadcast-adv-parameters
branch
from
8bfda4b
to
2845165
Compare
anangl
requested review from
anangl,
carlescufi,
de-nordic,
nordic-krch and
a team
as code owners
Frodevan
force-pushed
the
bt-tester-broadcast-adv-parameters
branch
2 times, most recently
from
9a80a0c
to
6dcda26
Compare
alexsven
approved these changes
Jul 9, 2024
This change removes the BT_LE_PER_ADV_OPT_USE_TX_POWER option for extended advertisement in BLE Audio PTS tests. The Broadcaster setup options was hardcoded to include the BT_LE_PER_ADV_OPT_USE_TX_POWER option. This causes incompabilities for any controller not support it, and since the option is not required for the audio tests it should not be used here. Upstream PR: zephyrproject-rtos/zephyr#73361 signed-off-by: Frode van der Meeren <[email protected]>
Frodevan
force-pushed
the
bt-tester-broadcast-adv-parameters
branch
from
6dcda26
to
bfcd672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Broadcaster setup has been hardcoded to include the BT_LE_PER_ADV_OPT_USE_TX_POWER parameter. This may cause incompabilities should the controller not support it, and since the feature may not be required for most broadcast tests it should not be forced.
Upstream PR: zephyrproject-rtos/zephyr#73361