-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: drivers: spi_flash: fix compilation #73302
samples: drivers: spi_flash: fix compilation #73302
Conversation
This change fixes the sample for every board in tree:
|
is this really what we want though? By that logic we should also remove things like |
I misremembered the conversation in #72519 concerning the support for removing the alias. I would argue the alias doesn't provide much value, I would expect that any application complex enough to use two external flashes is not operating through a flash0 flash1 alias. Mostly because the names provide no information on the differences between the two. I would also expect that most complex applications are running through the flash map API anyway, as writing directly to flash is obviously risky without defined areas for different systems. The cost of keeping it is going to be repeated CI failures whenever a board is added that has an external flash but doesn't populate the alias. Not a high cost, but annoying. |
This reverts commit b1de9a6. Signed-off-by: Jordan Yates <[email protected]>
This reverts commit 29f8187. Signed-off-by: Jordan Yates <[email protected]>
Get the flash device from the node compatible, instead of an alias. This removes the need for the `spi-flash0` alias on every board with one of these drivers. Signed-off-by: Jordan Yates <[email protected]>
As `samples/drivers/spi_flash` no longer needs this alias, there is no use for it on boards. Signed-off-by: Jordan Yates <[email protected]>
c7f1b27
to
bba76bf
Compare
Rebased due to file conflicts |
Fix two issues relating to compilation of this sample:
spi-flash0
alias on STM development kitResolve the second by removing the requirements for the alias, and then removing it from all boards, as this is the only application that uses it.