Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infineon: flash driver failing CI #73311

Closed
JordanYates opened this issue May 27, 2024 · 9 comments
Closed

infineon: flash driver failing CI #73311

JordanYates opened this issue May 27, 2024 · 9 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug platform: Infineon Infineon Technologies AG priority: high High impact/importance bug

Comments

@JordanYates
Copy link
Collaborator

Describe the bug

The following test is failing due to HAL misconfiguration, causing CI failures in #73302

west build -b cyw920829m2evk_02 tests/drivers/flash/common -T drivers.flash.common.default

Cause appears to be that CYHAL_DRIVER_AVAILABLE_NVM is not defined, I don't know enough (anything) about Infineon HAL to diagnose further.

Impact
CI failures

Logs and console output

/home/jordan/zephyr-sdk-0.16.5/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd: zephyr/drivers/flash/libdrivers__flash.a(flash_ifx_cat1.c.obj): in function `ifx_cat1_flash_erase':
/home/jordan/code/zephyr/zephyr/drivers/flash/flash_ifx_cat1.c:130: undefined reference to `cyhal_nvm_erase'
/home/jordan/zephyr-sdk-0.16.5/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd: zephyr/drivers/flash/libdrivers__flash.a(flash_ifx_cat1.c.obj): in function `ifx_cat1_flash_init':
/home/jordan/code/zephyr/zephyr/drivers/flash/flash_ifx_cat1.c:176: undefined reference to `cyhal_nvm_init'
/home/jordan/zephyr-sdk-0.16.5/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd: zephyr/drivers/flash/libdrivers__flash.a(flash_ifx_cat1.c.obj): in function `ifx_cat1_flash_write':
/home/jordan/code/zephyr/zephyr/drivers/flash/flash_ifx_cat1.c:96: undefined reference to `cyhal_nvm_write'
/home/jordan/zephyr-sdk-0.16.5/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd: zephyr/drivers/flash/libdrivers__flash.a(flash_ifx_cat1.c.obj): in function `ifx_cat1_flash_read':
/home/jordan/code/zephyr/zephyr/drivers/flash/flash_ifx_cat1.c:63: undefined reference to `cyhal_nvm_read'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /usr/bin/cmake --build /home/jordan/code/zephyr/zephyr/build

Environment (please complete the following information):

@JordanYates JordanYates added bug The issue is a bug, or the PR is fixing a bug platform: Infineon Infineon Technologies AG labels May 27, 2024
@aescolar aescolar added the priority: high High impact/importance bug label May 27, 2024
@aescolar
Copy link
Member

aescolar commented May 28, 2024

This problem has been present since the introduction of this target in f96e6cc
#70961

@aescolar
Copy link
Member

CC @sreeramIfx

@sreeramIfx
Copy link
Contributor

sreeramIfx commented May 28, 2024

I have pushed a fix (#73377) and closed it since its being updated in #73267 as well. Since this PR is approved it should me merged soon..

@JordanYates
Copy link
Collaborator Author

I have pushed a fix (#73377) and closed it since its being updated in #73267 as well. Since this PR is approved it should me merged soon..

That is not going to resolve this issue as it is a different test application.
Simply excluding the platform from individual tests is not going to solve the root cause.

@sreeramIfx
Copy link
Contributor

I am working on a PR to address the root cause, Please let me know if there is a better way to unblock other PR's in the meanwhile.

@tomi-font
Copy link
Collaborator

Great. For my part just make sure to revert the excluding of the platform in #73267.

@aescolar
Copy link
Member

@sreeramIfx @ifyall What is the status on this issue?

@sreeramIfx
Copy link
Contributor

There was another issue created for the same error(#73525), This is fixed @ #73552

@aescolar
Copy link
Member

Thanks @sreeramIfx . Closing as duplicate (and fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug platform: Infineon Infineon Technologies AG priority: high High impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants