Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: arm: Add initial support for Renesas EK-RA2A1 #71174

Merged
merged 2 commits into from
Aug 21, 2024
Merged

boards: arm: Add initial support for Renesas EK-RA2A1 #71174

merged 2 commits into from
Aug 21, 2024

Conversation

soburi
Copy link
Member

@soburi soburi commented Apr 6, 2024 •
edited
Loading

Add support for the Renesas EK-RA2A board.

This commit provides basic support only.
It just can run blinky and button samples.

@soburi soburi added the DNM This PR should not be merged (Do Not Merge) label Apr 6, 2024
@soburi soburi changed the title Ek ra2a1 boards: arm: Add initial support for Renesas EK-RA2A1 Apr 6, 2024
@soburi soburi force-pushed the ek-ra2a1 branch 2 times, most recently from ae79a4a to 66a376f Compare April 6, 2024 06:28
@soburi soburi mentioned this pull request Apr 6, 2024
Closed
4 tasks
@soburi
Copy link
Member Author

soburi commented Apr 6, 2024

It needs to rebase after #71017 is merged.

@soburi soburi mentioned this pull request Apr 6, 2024
Merged
nordicjm
nordicjm reviewed Apr 8, 2024
View reviewed changes
soc/renesas/ra/ra2a1/Kconfig Outdated
Comment on lines 27 to 35
config SOC_OPTION_SETTING_HOCO_FREQ
int "HOCO oscillator frequency"
default 48000000
depends on SOC_OPTION_SETTING_MEMORY

config SOC_OPTION_SETTING_VDSEL
int "Voltage Detection 0 Level Select"
default 1900
depends on SOC_OPTION_SETTING_MEMORY
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be dts properties

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing.
This issue discussed in #71017.
I will apply the result of discussions.

soc/renesas/ra/ra2a1/Kconfig Outdated
select TIMER_READS_ITS_FREQUENCY_AT_RUNTIME
select XIP

config SOC_OPTION_SETTING_MEMORY
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if SOC_SERIES_RA2A1

@soburi soburi force-pushed the ek-ra2a1 branch 7 times, most recently from 2a54453 to e0cb658 Compare April 26, 2024 20:52
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jun 4, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@soburi
Copy link
Member Author

soburi commented Jun 4, 2024

Reimplementing on the FSP code base (#72150)

@zephyrbot zephyrbot removed manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Jun 30, 2024
@soburi soburi force-pushed the ek-ra2a1 branch 3 times, most recently from a1588af to aa7df0e Compare July 4, 2024 10:29
@soburi soburi requested a review from thaoluonguw August 8, 2024 10:35
ydamigos
ydamigos requested changes Aug 12, 2024
View reviewed changes
west.yml Outdated
@@ -214,7 +214,7 @@ manifest:
- hal
- name: hal_renesas
path: modules/hal/renesas
revision: af77d7cdfeeff290593e7e99f54f0c1e2a3f91e6
revision: 24543f3187ed90c4556466d0fe6b4cd948140648
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use the latest hash.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update done.

Copy link
Collaborator

@ydamigos ydamigos Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAL was updated yesterday. Please update it once more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update done.

@soburi soburi requested a review from ydamigos August 12, 2024 23:21
@soburi
Copy link
Member Author

soburi commented Aug 14, 2024

@duynguyenxa @ydamigos @KhiemNguyenT @thaoluonguw

Could you take a look again, please?

@ydamigos
Copy link
Collaborator

Could you take a look again, please?

HAL was updated yesterday. Please update west.yml once more.

@soburi
Copy link
Member Author

soburi commented Aug 14, 2024

@ydamigos

Could you take a look again, please?

HAL was updated yesterday. Please update west.yml once more.

Update done.

KhiemNguyenT
KhiemNguyenT reviewed Aug 14, 2024
View reviewed changes
MAINTAINERS.yml Outdated Show resolved Hide resolved
thenguyenyf
thenguyenyf reviewed Aug 14, 2024
View reviewed changes
soc/renesas/ra/ra2a1/soc.c
{
SystemCoreClock = BSP_MOCO_HZ;
g_protect_pfswe_counter = 0;
bsp_clock_init();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function have been called in clock_control init routine. It should be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please re-check? I see it still exists.

boards/renesas/ek_ra2a1/ek_ra2a1_defconfig
CONFIG_CONSOLE=y

CONFIG_BUILD_OUTPUT_HEX=y
CONFIG_BUILD_NO_GAP_FILL=y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this config if you want to use the clock_control
CONFIG_CLOCK_CONTROL=y

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

@soburi
soc: renesas: ra: Add RA2A1 SoC support
159ee68 
Add Support for Renesas RA2A1 SoC.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
boards: arm: Add initial support for EKRA2A1
b771895 
Add support for the EK-RA2A1 board.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
Copy link
Member Author

soburi commented Aug 21, 2024

@KhiemNguyenT
Could you recheck and reapprove, please?

@henrikbrixandersen henrikbrixandersen merged commit e0c892f into zephyrproject-rtos:main Aug 21, 2024
23 checks passed
@soburi soburi deleted the ek-ra2a1 branch August 21, 2024 07:59
@ydamigos ydamigos mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydamigos ydamigos ydamigos approved these changes

@KhiemNguyenT KhiemNguyenT KhiemNguyenT approved these changes

@thaoluonguw thaoluonguw thaoluonguw approved these changes

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter

@cfriedt cfriedt Awaiting requested review from cfriedt

@dcpleung dcpleung Awaiting requested review from dcpleung

@galak galak Awaiting requested review from galak

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@stephanosio stephanosio Awaiting requested review from stephanosio

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

@duynguyenxa duynguyenxa Awaiting requested review from duynguyenxa

@nordicjm nordicjm Awaiting requested review from nordicjm

@thenguyenyf thenguyenyf Awaiting requested review from thenguyenyf

Assignees

@KhiemNguyenT KhiemNguyenT

Labels
area: C++ area: Clock Control area: Devicetree Binding PR modifies or adds a Device Tree binding area: Process area: UART Universal Asynchronous Receiver-Transmitter platform: Renesas RA Renesas Electronics Corporation, RA platforms: Renesas RA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@soburi @zephyrbot @ydamigos @KhiemNguyenT @nordicjm @thaoluonguw @thenguyenyf @duynguyenxa @henrikbrixandersen @dcpleung