boards: esp32: Add support for M5Stack AtomS3 #64434

kartben · 2023-10-26T09:40:36Z

This introduces support for the ESP32S3 based M5Stack AtomS3.

Tested all of the following:

LCD display and accelerometer tested with samples/modules/lvgl/accelerometer_chart, which works out-of-the-box (see below!)
Button (samples/basic/button and samples/subsys/display/lvgl sample)
Bluetooth (samples/bluetooth/peripheral_hr)
Wi-Fi (samples/net/wifi, wifi scan works)
Grove connector, tested with samples/sensor/sensor_shell and an I2C device attached

Doc page: https://builds.zephyrproject.io/zephyr/pr/64434/docs/boards/xtensa/m5stack_atoms3/doc/index.html

Pxl.20231026.101330936.webm

kartben · 2023-10-26T17:45:39Z

The first two commits are part of PR #64451 so you may ignore them.

sylvioalves · 2023-10-27T05:16:49Z

@kartben awesome!

kartben · 2023-10-27T08:16:31Z

Rebased as the 2 commits mentioned earlier are not needed anymore now that 1fac5ed fixed the issue with Xtensa CI.

kartben · 2023-10-28T22:45:49Z

@sylvioalves should I exclude this board from tests/lib/heap testcase, like other (but not all??) esp32-s2 and s3? I don't think the test failed in earlier runs though, but not 100% sure.

kartben · 2023-11-09T18:26:54Z

@sylvioalves @marekmatej what should I be doing with the failing heap test? should I just add this board as a platform_exclude in the testcase? There are other ESP32S3 that are working just fine (but also some that are excluded).

FAILED: zephyr/zephyr_pre0.elf zephyr/zephyr_pre0.map /__w/zephyr/zephyr/twister-out/m5stack_atoms3/tests/lib/heap/libraries.heap/zephyr/zephyr_pre0.map 
: && ccache /opt/toolchains/zephyr-sdk-0.16.3/xtensa-espressif_esp32s3_zephyr-elf/bin/xtensa-espressif_esp32s3_zephyr-elf-gcc  -gdwarf-4 zephyr/CMakeFiles/zephyr_pre0.dir/misc/empty_file.c.obj -o zephyr/zephyr_pre0.elf  zephyr/CMakeFiles/offsets.dir/./arch/xtensa/core/offsets/offsets.c.obj  -fuse-ld=bfd  -T  zephyr/linker_zephyr_pre0.cmd  -Wl,-Map=/__w/zephyr/zephyr/twister-out/m5stack_atoms3/tests/lib/heap/libraries.heap/zephyr/zephyr_pre0.map  -Wl,--whole-archive  app/libapp.a  zephyr/libzephyr.a  zephyr/arch/common/libarch__common.a  zephyr/arch/arch/xtensa/core/libarch__xtensa__core.a  zephyr/lib/libc/picolibc/liblib__libc__picolibc.a  zephyr/lib/libc/common/liblib__libc__common.a  zephyr/lib/posix/liblib__posix.a  zephyr/subsys/random/libsubsys__random.a  zephyr/subsys/testsuite/ztest/libsubsys__testsuite__ztest.a  zephyr/drivers/interrupt_controller/libdrivers__interrupt_controller.a  zephyr/drivers/clock_control/libdrivers__clock_control.a  zephyr/drivers/console/libdrivers__console.a  zephyr/drivers/entropy/libdrivers__entropy.a  zephyr/drivers/gpio/libdrivers__gpio.a  zephyr/drivers/pinctrl/libdrivers__pinctrl.a  zephyr/drivers/regulator/libdrivers__regulator.a  zephyr/drivers/serial/libdrivers__serial.a  zephyr/drivers/timer/libdrivers__timer.a  -Wl,--no-whole-archive  zephyr/kernel/libkernel.a  -L"/opt/toolchains/zephyr-sdk-0.16.3/xtensa-espressif_esp32s3_zephyr-elf/bin/../lib/gcc/xtensa-espressif_esp32s3_zephyr-elf/12.2.0"  -L/__w/zephyr/zephyr/twister-out/m5stack_atoms3/tests/lib/heap/libraries.heap/zephyr  -lgcc  zephyr/arch/common/libisr_tables.a  -lgcc  -Wl,--fatal-warnings  -Wl,--gc-sections  -Wl,--build-id=none  -Wl,--sort-common=descending  -Wl,--sort-section=alignment  -Wl,-u,_OffsetAbsSyms  -Wl,-u,_ConfigAbsSyms  -nostdlib  -static  -Wl,-X  -Wl,-N  -Wl,--orphan-handling=warn  -Wl,-no-pie  -DPICOLIBC_INTEGER_PRINTF_SCANF  -T/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/src/linker/esp32s3.rom.alias.ld  -T/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_rom/esp32s3/ld/esp32s3.rom.ld  -T/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_rom/esp32s3/ld/esp32s3.rom.api.ld  -T/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_rom/esp32s3/ld/esp32s3.rom.libgcc.ld  -T/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_rom/esp32s3/ld/esp32s3.rom.newlib.ld  -T/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/esp_rom/esp32s3/ld/esp32s3.rom.version.ld  -T/__w/zephyr/modules/hal/espressif/zephyr/esp32s3/../../components/soc/esp32s3/ld/esp32s3.peripherals.ld  -Wl,--wrap=k_calloc  -Wl,--wrap=k_malloc  --specs=picolibc.specs  -lc  -lgcc && cd /__w/zephyr/zephyr/twister-out/m5stack_atoms3/tests/lib/heap/libraries.heap/zephyr && /usr/bin/cmake -E true
/opt/toolchains/zephyr-sdk-0.16.3/xtensa-espressif_esp32s3_zephyr-elf/bin/../lib/gcc/xtensa-espressif_esp32s3_zephyr-elf/12.2.0/../../../../xtensa-espressif_esp32s3_zephyr-elf/bin/ld.bfd: zephyr/zephyr_pre0.elf section `.dram0.data' will not fit in region `dram0_0_seg'
/opt/toolchains/zephyr-sdk-0.16.3/xtensa-espressif_esp32s3_zephyr-elf/bin/../lib/gcc/xtensa-espressif_esp32s3_zephyr-elf/12.2.0/../../../../xtensa-espressif_esp32s3_zephyr-elf/bin/ld.bfd: region `dram0_0_seg' overflowed by 1536 bytes
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

sylvioalves · 2023-11-09T19:56:10Z

boards/xtensa/m5stack_atoms3/m5stack_atoms3_defconfig

+CONFIG_UART_CONSOLE=y
+
+# for debugging
+CONFIG_SHELL=y


I suggest removing this as default config. This will allow test/lib/heap to pass. User can manually enable this if necessary. Sounds good?

Sure thing! Definitely the right thing to do. Pretty sure I copy pasted from another esp32 board fwiw, including the "for debugging" comment.

sylvioalves · 2023-11-09T19:56:42Z

boards/xtensa/m5stack_atoms3/m5stack_atoms3_defconfig

+
+CONFIG_MAIN_STACK_SIZE=2048
+
+CONFIG_ESP_HEAP_MEM_POOL_REGION_1_SIZE=0


This is not needed nor available for ESP32S3. Only for ESP32 that has dual ram bank. So you can remove it from here.

sylvioalves · 2023-11-09T19:57:49Z

@sylvioalves should I exclude this board from tests/lib/heap testcase, like other (but not all??) esp32-s2 and s3? I don't think the test failed in earlier runs though, but not 100% sure.

If you remove the CONFIG_SHELL=y, test will pass.

kartben · 2023-11-09T22:08:30Z

@sylvioalves should I exclude this board from tests/lib/heap testcase, like other (but not all??) esp32-s2 and s3? I don't think the test failed in earlier runs though, but not 100% sure.

If you remove the CONFIG_SHELL=y, test will pass.

Thanks for your help! All green now!
Let me know who else you think could help reviewing this PR btw, as it hasn't had a lot of traction in the past two weeks. Thanks!

sylvioalves · 2023-11-09T22:09:39Z

@marekmatej @LucasTambor PTAL

boards/xtensa/m5stack_atoms3/support/openocd.cfg

boards/xtensa/m5stack_atoms3/m5stack_atoms3.yaml

This introduces support for the ESP32S3 based M5Stack AtomS3. Signed-off-by: Benjamin Cabé <[email protected]>

s/espressif/extensa/ for the couple M5Stack boards in-tree that had the wrong vendor set. Signed-off-by: Benjamin Cabé <[email protected]>

marekmatej

some nitpicks, but looks good

marekmatej · 2023-11-10T11:00:47Z

boards/xtensa/m5stack_atoms3/board.cmake

+if(NOT "${OPENOCD}" MATCHES "^${ESPRESSIF_TOOLCHAIN_PATH}/.*")
+  set(OPENOCD OPENOCD-NOTFOUND)
+endif()
+find_program(OPENOCD openocd PATHS ${ESPRESSIF_TOOLCHAIN_PATH}/openocd-esp32/bin NO_DEFAULT_PATH)


Since debugging is not supported, maybe consider reducing this file to single line:
include(${ZEPHYR_BASE}/boards/common/esp32.board.cmake)

marekmatej · 2023-11-10T11:10:10Z

boards/xtensa/m5stack_atoms3/m5stack_atoms3-pinctrl.dtsi

+			pinmux = <SPIM2_MOSI_GPIO21>;
+			output-low;
+		};
+


remove blank line

kartben force-pushed the m5stack_atoms3 branch 8 times, most recently from 9f1f09e to 1eccaec Compare October 26, 2023 17:44

kartben marked this pull request as ready for review October 26, 2023 17:45

kartben requested review from nashif and dcpleung as code owners October 26, 2023 17:45

zephyrbot added the area: Debugging label Oct 26, 2023

zephyrbot requested a review from mrkhldn October 26, 2023 17:45

zephyrbot assigned nashif Oct 26, 2023

kartben added area: Boards platform: ESP32 Espressif ESP32 and removed area: Debugging labels Oct 26, 2023

kartben assigned sylvioalves and unassigned nashif Oct 26, 2023

kartben requested review from marekmatej and sylvioalves October 26, 2023 19:59

sylvioalves previously approved these changes Oct 27, 2023

View reviewed changes

sylvioalves requested a review from LucasTambor October 27, 2023 05:17

kartben dismissed sylvioalves’s stale review via 1ae8367 October 27, 2023 08:15

kartben force-pushed the m5stack_atoms3 branch from 1eccaec to 1ae8367 Compare October 27, 2023 08:15

kartben requested a review from sylvioalves October 27, 2023 08:16

sylvioalves previously approved these changes Oct 28, 2023

View reviewed changes

sylvioalves reviewed Nov 9, 2023

View reviewed changes

kartben dismissed sylvioalves’s stale review via 72e993a November 9, 2023 21:32

kartben force-pushed the m5stack_atoms3 branch from 1ae8367 to 72e993a Compare November 9, 2023 21:32

kartben requested a review from sylvioalves November 9, 2023 22:05

sylvioalves previously approved these changes Nov 9, 2023

View reviewed changes

LucasTambor reviewed Nov 9, 2023

View reviewed changes

boards/xtensa/m5stack_atoms3/support/openocd.cfg Outdated Show resolved Hide resolved

sylvioalves reviewed Nov 10, 2023

View reviewed changes

boards/xtensa/m5stack_atoms3/m5stack_atoms3.yaml Outdated Show resolved Hide resolved

boards: esp32: Add support for M5Stack AtomS3

19ed13d

This introduces support for the ESP32S3 based M5Stack AtomS3. Signed-off-by: Benjamin Cabé <[email protected]>

kartben dismissed sylvioalves’s stale review via c38f3db November 10, 2023 09:15

kartben force-pushed the m5stack_atoms3 branch from 72e993a to c38f3db Compare November 10, 2023 09:15

kartben requested review from LucasTambor and sylvioalves November 10, 2023 09:17

boards: xtensa: Set M5Stack vendor for M5Stack boards

2579c7c

s/espressif/extensa/ for the couple M5Stack boards in-tree that had the wrong vendor set. Signed-off-by: Benjamin Cabé <[email protected]>

kartben force-pushed the m5stack_atoms3 branch from c38f3db to 2579c7c Compare November 10, 2023 09:20

LucasTambor approved these changes Nov 10, 2023

View reviewed changes

marekmatej reviewed Nov 10, 2023

View reviewed changes

marekmatej approved these changes Nov 10, 2023

View reviewed changes

carlescufi merged commit 1fbcccd into zephyrproject-rtos:main Nov 14, 2023
16 checks passed

kartben deleted the m5stack_atoms3 branch November 15, 2023 10:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: esp32: Add support for M5Stack AtomS3 #64434

boards: esp32: Add support for M5Stack AtomS3 #64434

kartben commented Oct 26, 2023 •

edited

Loading

kartben commented Oct 26, 2023

sylvioalves commented Oct 27, 2023

kartben commented Oct 27, 2023

kartben commented Oct 28, 2023

kartben commented Nov 9, 2023

sylvioalves Nov 9, 2023

kartben Nov 9, 2023

sylvioalves Nov 9, 2023

sylvioalves commented Nov 9, 2023 •

edited

Loading

kartben commented Nov 9, 2023

sylvioalves commented Nov 9, 2023

marekmatej left a comment

marekmatej Nov 10, 2023

marekmatej Nov 10, 2023


		CONFIG_MAIN_STACK_SIZE=2048

		CONFIG_ESP_HEAP_MEM_POOL_REGION_1_SIZE=0

boards: esp32: Add support for M5Stack AtomS3 #64434

boards: esp32: Add support for M5Stack AtomS3 #64434

Conversation

kartben commented Oct 26, 2023 • edited Loading

kartben commented Oct 26, 2023

sylvioalves commented Oct 27, 2023

kartben commented Oct 27, 2023

kartben commented Oct 28, 2023

kartben commented Nov 9, 2023

sylvioalves Nov 9, 2023

Choose a reason for hiding this comment

kartben Nov 9, 2023

Choose a reason for hiding this comment

sylvioalves Nov 9, 2023

Choose a reason for hiding this comment

sylvioalves commented Nov 9, 2023 • edited Loading

kartben commented Nov 9, 2023

sylvioalves commented Nov 9, 2023

marekmatej left a comment

Choose a reason for hiding this comment

marekmatej Nov 10, 2023

Choose a reason for hiding this comment

marekmatej Nov 10, 2023

Choose a reason for hiding this comment

kartben commented Oct 26, 2023 •

edited

Loading

sylvioalves commented Nov 9, 2023 •

edited

Loading