Host Command fixes #59783
Merged
Host Command fixes #59783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the response buffer size, passed to a command handler, every command, since a backend could change it in runtime. Signed-off-by: Dawid Niedzwiecki <[email protected]>
The response buffer has to be cleared every command not to pass unintended content e.g. response from a previous command, or stack content. Signed-off-by: Dawid Niedzwiecki <[email protected]>
The sizeof is used in a wrong way which causes incorrect checking a version of a command. Use NUM_BITS instead. Signed-off-by: Dawid Niedzwiecki <[email protected]>
niedzwiecki-dawid
force-pushed
the
hc_fix
branch
from
a260357
to
624c404
Compare
fabiobaltieri
approved these changes
Jul 3, 2023
keith-zephyr
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few Host Command subsystem fixes:
-checking a command version
-clearing response buffer
-setting response buffer size every command