mgmt: ec_host_cmd: fix checking command version

The sizeof is used in a wrong way which causes incorrect checking a version of a command. Use NUM_BITS instead. Signed-off-by: Dawid Niedzwiecki <[email protected]>
zephyrproject-rtos · Jul 7, 2023 · 40924ed · 40924ed
1 parent 521f0ba
commit 40924ed
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/subsys/mgmt/ec_host_cmd/ec_host_cmd_handler.c b/subsys/mgmt/ec_host_cmd/ec_host_cmd_handler.c
@@ -123,7 +123,7 @@ static enum ec_host_cmd_status validate_handler(const struct ec_host_cmd_handler
 		return EC_HOST_CMD_INVALID_RESPONSE;
 	}
 
-	if (args->version > sizeof(handler->version_mask) ||
+	if (args->version >= NUM_BITS(handler->version_mask) ||
 	    !(handler->version_mask & BIT(args->version))) {
 		return EC_HOST_CMD_INVALID_VERSION;
 	}