-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add STM32L451 #59763
Add STM32L451 #59763
Conversation
My approach was to copy the files from the L452 and work through the differences of these two MCUs according to their datasheets. I tested it on a custom PCB, and the basic functionality (RCC, clocks, UART, GPIOs, UART, ...) is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved because it seems correct, but from what I see, the only difference between L451 and L452 is the USB in the 52. Thus, it would be nice to include the 51 in the 52, and remove all nodes but the USB. That would avoid unnecessary duplication.
a1fc500
to
7d7e06b
Compare
7d7e06b
to
4cb162b
Compare
I introduced a base called L45 and included it in L451 and L452. |
Thank you for this, but I don't think it is necessary to introduce a stm32l45.dtsi. It is perfectly fine to use stm32l451.dtsi as a base. This is how it's done on other series and it would be better to keep the same structure. |
Add the MCU STM32L451. Signed-off-by: Benedikt Schmidt <[email protected]>
4cb162b
to
603fd76
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Add the MCU STM32L451.