boards: xtensa: Add support for xiao esp32s3 #59732
Conversation
| }; | ||
| }; | ||
|
|
||
| power-states { |
There was a problem hiding this comment.
I think that ESP32-S3 has no low power implemented yet. This can be removed.
There was a problem hiding this comment.
It is WIP: zephyrproject-rtos/hal_espressif#210
There was a problem hiding this comment.
ok, I removed it now.
|
@Maxwelltoo, you have to compress the images to less than 100kB I think. Can you re-check? |
They're OK now -- but you're right that CI caught issues with them being too big in an earlier version of the PR. |
| .. _xiao_esp32s3: | ||
|
|
||
| XIAO ESP32S3 | ||
| ############### |
There was a problem hiding this comment.
CI is failing. If not the image size then it might be here. Too many #?
There was a problem hiding this comment.
CI is failing. If not the image size then it might be here. Too many
#?
Although these are definitely extra #s, I don't see CI failing?
There was a problem hiding this comment.
When I wrote the comment before, it failed in documentation. I re-triggered and it passed.
There was a problem hiding this comment.
so... I need to delete these # ? @sylvioalves
There was a problem hiding this comment.
Just the "extra" ones:
| ############### | |
| ############ |
Maxwelltoo
force-pushed
the
main
branch
2 times, most recently
from
7f3436a
to
2f5068f
Compare
add board support and overlay for seeed xiao esp32s3. Signed-off-by: Jiaxuan Weng <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @Maxwelltoo!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!
To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.
Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁
add board support for seeed xiao esp32s3.