usb: device_next: align CDC ACM UART with Interrupt-driven UART API #152439
compliance.yml
on: pull_request
Run compliance checks on patch series (PR)
2m 18s
Annotations
1 error, 1 warning, and 3 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
Run compliance checks on patch series (PR):
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-static ALWAYS_INLINE int cdc_acm_work_schedule(struct k_work_delayable *work,
- k_timeout_t delay)
+static ALWAYS_INLINE int cdc_acm_work_schedule(struct k_work_delayable *work, k_timeout_t delay)
File:subsys/usb/device_next/class/usbd_cdc_acm.c
Line:145
You may want to run clang-format on this change:
- cfg->flow_ctrl = data->flow_ctrl ? UART_CFG_FLOW_CTRL_RTS_CTS :
- UART_CFG_FLOW_CTRL_NONE;
+ cfg->flow_ctrl = data->flow_ctrl ? UART_CFG_FLOW_CTRL_RTS_CTS : UART_CFG_FLOW_CTRL_NONE;
File:subsys/usb/device_next/class/usbd_cdc_acm.c
Line:387
You may want to run clang-format on this change:
-#define USBD_CDC_ACM_DT_DEVICE_DEFINE(n) \
- BUILD_ASSERT(DT_INST_ON_BUS(n, usb), \
- "node " DT_NODE_PATH(DT_DRV_INST(n)) \
- " is not assigned to a USB device controller"); \
- \
- CDC_ACM_DEFINE_DESCRIPTOR(n); \
- \
- USBD_DEFINE_CLASS(cdc_acm_##n, \
- &usbd_cdc_acm_api, \
- (void *)DEVICE_DT_GET(DT_DRV_INST(n)), NULL); \
- \
- RING_BUF_DECLARE(cdc_acm_rb_rx_##n, DT_INST_PROP(n, rx_fifo_size)); \
- RING_BUF_DECLARE(cdc_acm_rb_tx_##n, DT_INST_PROP(n, tx_fifo_size)); \
- \
- static struct cdc_acm_uart_data uart_data_##n = { \
- .line_coding = CDC_ACM_DEFAULT_LINECODING, \
- .c_data = &cdc_acm_##n, \
- .rx_fifo.rb = &cdc_acm_rb_rx_##n, \
- .tx_fifo.rb = &cdc_acm_rb_tx_##n, \
- .flow_ctrl = DT_INST_PROP(n, hw_flow_control), \
- .notif_sem = Z_SEM_INITIALIZER(uart_data_##n.notif_sem, 0, 1), \
- .desc = &cdc_acm_desc_##n, \
- .fs_desc = cdc_acm_fs_desc_##n, \
- .hs_desc = cdc_acm_hs_desc_##n, \
- }; \
- \
- DEVICE_DT_INST_DEFINE(n, usbd_cdc_acm_preinit, NULL, \
- &uart_data_##n, NULL, \
- PRE_KERNEL_1, CONFIG_SERIAL_INIT_PRIORITY, \
- &cdc_acm_uart_api);
+#define USBD_CDC_ACM_DT_DEVICE_DEFINE(n) \
+ BUILD_ASSERT(DT_INST_ON_BUS(n, usb), \
+ "node " DT_NODE_PATH( \
+ DT_DRV_INST(n)) " is not assigned to a USB device controller"); \
+ \
+ CDC_ACM_DEFINE_DESCRIPTOR(n); \
+ \
+ USBD_DEFINE_CLASS(cdc_acm_##n, &usbd_cdc_acm_api, (void *)DEVICE_DT_GET(DT_DRV_INST(n)), \
+ NULL); \
+ \
+ RING_BUF_DECLARE(cdc_acm_rb_rx_##n, DT_INST_PROP(n, rx_fifo_size)); \
+ RING_BUF_DECLARE(cdc_acm_rb_tx_##n, DT_INST_PROP(n, tx_fifo_size)); \
+ \
+ static struct cdc_acm_uart_data uart_data_##n = { \
+ .line_coding = CDC_ACM_DEFAULT_LINECODING, \
+ .c_data = &cdc_acm_##n, \
+ .rx_fifo.rb = &cdc_acm_rb_rx_##n, \
+ .tx_fifo.rb = &cdc_acm_rb_tx_##n, \
+ .flow_ctrl = DT_INST_PROP(n, hw_flow_control), \
+ .notif_sem = Z_SEM_INITIALIZER(uart_data_##n.notif_sem, 0, 1), \
+ .desc = &cdc_acm_desc_##n, \
+ .fs_desc = cdc_acm_fs_desc_##n, \
+ .hs_desc = cdc_acm_hs_desc_##n,
|
You may want to run clang-format on this change:
subsys/usb/device_next/class/usbd_cdc_acm.c#L145
subsys/usb/device_next/class/usbd_cdc_acm.c:145
-static ALWAYS_INLINE int cdc_acm_work_schedule(struct k_work_delayable *work,
- k_timeout_t delay)
+static ALWAYS_INLINE int cdc_acm_work_schedule(struct k_work_delayable *work, k_timeout_t delay)
|
You may want to run clang-format on this change:
subsys/usb/device_next/class/usbd_cdc_acm.c#L387
subsys/usb/device_next/class/usbd_cdc_acm.c:387
- cfg->flow_ctrl = data->flow_ctrl ? UART_CFG_FLOW_CTRL_RTS_CTS :
- UART_CFG_FLOW_CTRL_NONE;
+ cfg->flow_ctrl = data->flow_ctrl ? UART_CFG_FLOW_CTRL_RTS_CTS : UART_CFG_FLOW_CTRL_NONE;
|
You may want to run clang-format on this change:
subsys/usb/device_next/class/usbd_cdc_acm.c#L1250
subsys/usb/device_next/class/usbd_cdc_acm.c:1250
-#define USBD_CDC_ACM_DT_DEVICE_DEFINE(n) \
- BUILD_ASSERT(DT_INST_ON_BUS(n, usb), \
- "node " DT_NODE_PATH(DT_DRV_INST(n)) \
- " is not assigned to a USB device controller"); \
- \
- CDC_ACM_DEFINE_DESCRIPTOR(n); \
- \
- USBD_DEFINE_CLASS(cdc_acm_##n, \
- &usbd_cdc_acm_api, \
- (void *)DEVICE_DT_GET(DT_DRV_INST(n)), NULL); \
- \
- RING_BUF_DECLARE(cdc_acm_rb_rx_##n, DT_INST_PROP(n, rx_fifo_size)); \
- RING_BUF_DECLARE(cdc_acm_rb_tx_##n, DT_INST_PROP(n, tx_fifo_size)); \
- \
- static struct cdc_acm_uart_data uart_data_##n = { \
- .line_coding = CDC_ACM_DEFAULT_LINECODING, \
- .c_data = &cdc_acm_##n, \
- .rx_fifo.rb = &cdc_acm_rb_rx_##n, \
- .tx_fifo.rb = &cdc_acm_rb_tx_##n, \
- .flow_ctrl = DT_INST_PROP(n, hw_flow_control), \
- .notif_sem = Z_SEM_INITIALIZER(uart_data_##n.notif_sem, 0, 1), \
- .desc = &cdc_acm_desc_##n, \
- .fs_desc = cdc_acm_fs_desc_##n, \
- .hs_desc = cdc_acm_hs_desc_##n, \
- }; \
- \
- DEVICE_DT_INST_DEFINE(n, usbd_cdc_acm_preinit, NULL, \
- &uart_data_##n, NULL, \
- PRE_KERNEL_1, CONFIG_SERIAL_INIT_PRIORITY, \
- &cdc_acm_uart_api);
+#define USBD_CDC_ACM_DT_DEVICE_DEFINE(n) \
+ BUILD_ASSERT(DT_INST_ON_BUS(n, usb), \
+ "node " DT_NODE_PATH( \
+ DT_DRV_INST(n)) " is not assigned to a USB device controller"); \
+ \
+ CDC_ACM_DEFINE_DESCRIPTOR(n); \
+ \
+ USBD_DEFINE_CLASS(cdc_acm_##n, &usbd_cdc_acm_api, (void *)DEVICE_DT_GET(DT_DRV_INST(n)), \
+ NULL); \
+ \
+ RING_BUF_DECLARE(cdc_acm_rb_rx_##n, DT_INST_PROP(n, rx_fifo_size)); \
+ RING_BUF_DECLARE(cdc_acm_rb_tx_##n, DT_INST_PROP(n, tx_fifo_size)); \
+ \
+ static struct cdc_acm_uart_data uart_data_##n = { \
+ .line_coding = CDC_ACM_DEFAULT_LINECODING, \
+ .c_data = &cdc_acm_##n, \
+ .rx_fifo.rb = &cdc_acm_rb_rx_##n, \
+ .tx_fifo.rb = &cdc_acm_rb_tx_##n, \
+ .flow_ctrl = DT_INST_PROP(n, hw_flow_control), \
+ .notif_sem = Z_SEM_INITIALIZER(uart_data_##n.notif_sem, 0, 1), \
+ .desc = &cdc_acm_desc_##n, \
+ .fs_desc = cdc_acm_fs_desc_##n, \
+ .hs_desc = cdc_acm_hs_desc_##n, \
+ }; \
+ \
+ DEVICE_DT_INST_DEFINE(n, usbd_cdc_acm_preinit, NULL, &uart_data_##n, NULL, PRE_KERNEL_1, \
+ CONFIG_SERIAL_INIT_PRIORITY, &cdc_acm_uart_api);
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
compliance.xml
|
1.47 KB |
|