usb: device_next: align CDC ACM UART with Interrupt-driven UART API #75439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfischer-no
added
area: USB
tmon-nordic
reviewed
Aug 22, 2024
|
Commit "usb: device_next: allow fifo_fill and poll_out be used simultaneously" in this PR fixes #76642 |
jfischer-no
force-pushed
the
pr-doc-device-next-cdc-acm
branch
from
f576983
to
741d8a7
Compare
tmon-nordic
previously approved these changes
Sep 9, 2024
|
There is conflict in |
jfischer-no
force-pushed
the
pr-doc-device-next-cdc-acm
branch
from
741d8a7
to
ec6a853
Compare
tmon-nordic
previously approved these changes
Oct 1, 2024
carlescufi
previously approved these changes
Oct 1, 2024
|
@jfischer-no rebase needed |
Move "Built-in functions" section down and increase the heading. Signed-off-by: Johann Fischer <[email protected]>
Align CDC ACM UART with Interrupt-driven UART API behavior description. Use the same flags in uart_irq_rx_ready(), uart_irq_tx_ready(), and uart_irq_is_pending(), which are updated after each uart_irq_update() call. Allow TX FIFO to be filled if there is space. Signed-off-by: Johann Fischer <[email protected]>
In general, it mirrors what is described in Interrupt-driven API documentation, but here a little more explicitly and with a simplified example, so that we can finally chisel it into the stone. Signed-off-by: Johann Fischer <[email protected]>
Apply changes in commit c152e09 ("usb: device: cdc_acm: block in uart_poll_out() routine") to the new CDC ACM UART poll_out implementation. Signed-off-by: Johann Fischer <[email protected]>
As it is still accepted practice, allow fifo_fill and poll_out to be used simultaneously. The lock around fifo_fill was already in place. Signed-off-by: Johann Fischer <[email protected]>
Add note about CDC ACM virtual UART polling API behavior. Signed-off-by: Johann Fischer <[email protected]>
When the controller is connected to a full speed bus, regardless of whether the controller supports high speed or not, the transfer size for the bulk OUT endpoint should be equal to the MPS in the current configuration. Signed-off-by: Johann Fischer <[email protected]>
Use delayable work to reduce CPU load when there is no transfer flow in the host direction. This also improves the performance of poll out, as introduced in commit commit fed6bde ("usb: device: cdc_acm: send more than 1 byte in poll out") for the legacy CDC ACM implementation. Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
dismissed stale reviews from carlescufi and tmon-nordic
via
87d3827
jfischer-no
force-pushed
the
pr-doc-device-next-cdc-acm
branch
from
ec6a853
to
87d3827
Compare
tmon-nordic
approved these changes
Oct 2, 2024
carlescufi
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align CDC ACM UART with Interrupt-driven UART API behavior description.
Use the same flags in uart_irq_rx_ready(), uart_irq_tx_ready(), and
uart_irq_is_pending(), which are updated after each uart_irq_update()
call. Allow TX FIFO to be filled if there is space.
Add CDC ACM virtual UART Interrupt-driven API documentation.
Fixes #76642