ImagePane: Gallery and refactor #539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
Dlurak
force-pushed
the
images-refactor
branch
from
4f53570
to
b85502f
Compare
|
Thanks, another impressive work 🙂 The code is mostly fine, I have a few comments, but the UX design of the Slider has to be rethinked. And until this is done we can't merge it. I have spent a lot of time on this today, and I am not sure yet how to make a design which will allow to have much more images. Let me know, if you want me to submit the review comments and work on it. Even though, I am not sure how long it will take until I find inspiration and come up with a design I am comfortable with. For me, the Slider is very key component to the FeaturePanel and I want it to be as balanced and fluent as the current one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ImagePaneWikipedia and wikimedia commons categories know give the user a list of multiple images. Those are displayed in a grid. If there are more then four images the user can press a button to open a dialog to see all images.
Each image/gallery of multiple images know stretch from the left to the right. If the aspect ratio isn't right the space will be filled up with a blurred version of the image.
It wasn't clear anymore that these images are scrollable so now there are arrows on the left and right to make it clear and simple to switch the image.
The right arrow even is animted to motivate the user to try out more images.
Like discussed in Wikimedia audio files #524 audio files are filtered out now.
Notes
It would be quite hard to test the image fetcher for wikipedia images as they now have multiple requests. For this reason I've removed them
ToDo
Checklist