Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mz/move strings #1714

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,13 @@ test_high_level_api_gpu: install_rs_build_toolchain install_cargo_nextest
--features=$(TARGET_ARCH_FEATURE),integer,internal-keycache,gpu -p $(TFHE_SPEC) \
-E "test(/high_level_api::.*gpu.*/)"

.PHONY: test_strings # Run the tests for strings ci
test_strings: install_rs_build_toolchain
RUSTFLAGS="$(RUSTFLAGS)" cargo $(CARGO_RS_BUILD_TOOLCHAIN) test --profile $(CARGO_PROFILE) \
--features=$(TARGET_ARCH_FEATURE),boolean,shortint,integer,strings -p $(TFHE_SPEC) \
-- strings::


.PHONY: test_user_doc # Run tests from the .md documentation
test_user_doc: install_rs_build_toolchain
RUSTFLAGS="$(RUSTFLAGS)" cargo $(CARGO_RS_BUILD_TOOLCHAIN) test --profile $(CARGO_PROFILE) --doc \
Expand All @@ -788,11 +795,7 @@ test_user_doc_gpu: install_rs_build_toolchain
--features=$(TARGET_ARCH_FEATURE),boolean,shortint,integer,internal-keycache,gpu,zk-pok -p $(TFHE_SPEC) \
-- test_user_docs::

.PHONY: test_fhe_strings # Run tests for fhe_strings example
test_fhe_strings: install_rs_build_toolchain
RUSTFLAGS="$(RUSTFLAGS)" cargo $(CARGO_RS_BUILD_TOOLCHAIN) test --profile $(CARGO_PROFILE) \
--example fhe_strings \
--features=$(TARGET_ARCH_FEATURE),integer


.PHONY: test_regex_engine # Run tests for regex_engine example
test_regex_engine: install_rs_build_toolchain
Expand Down
4 changes: 1 addition & 3 deletions tasks/src/check_tfhe_docs_are_tested.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ const DIR_TO_IGNORE: [&str; 3] = [
"tfhe/tfhe-backward-compat-data",
];

const FILES_TO_IGNORE: [&str; 4] = [
const FILES_TO_IGNORE: [&str; 3] = [
// This contains fragments of code that are unrelated to TFHE-rs
"tfhe/docs/tutorials/sha256_bool.md",
// This contains fragments of code coming from the tutorial that cannot be run as a doctest
"tfhe/examples/fhe_strings/README.md",
// TODO: This contains code that could be executed as a trivium docstring
"apps/trivium/README.md",
// TODO: should we test this ?
Expand Down
5 changes: 1 addition & 4 deletions tfhe/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ bytemuck = "1.14.3"
boolean = []
shortint = ["dep:sha3"]
integer = ["shortint"]
strings = ["integer"]
internal-keycache = ["dep:lazy_static", "dep:fs2"]
gpu = ["dep:tfhe-cuda-backend"]
zk-pok = ["dep:tfhe-zk-pok"]
Expand Down Expand Up @@ -308,10 +309,6 @@ required-features = ["shortint", "internal-keycache"]

# Real use-case examples

[[example]]
name = "fhe_strings"
required-features = ["integer"]

[[example]]
name = "dark_market"
required-features = ["integer", "internal-keycache"]
Expand Down
53 changes: 0 additions & 53 deletions tfhe/examples/fhe_strings/README.md

This file was deleted.

162 changes: 0 additions & 162 deletions tfhe/examples/fhe_strings/main.rs

This file was deleted.

Loading
Loading