-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mz/move strings #1714
base: main
Are you sure you want to change the base?
Mz/move strings #1714
Conversation
ecd0212
to
3cea569
Compare
are we sure that we want to move strings into the hlapi module ? |
bef66d4
to
b917005
Compare
3cea569
to
59eeb63
Compare
Makefile
Outdated
# .PHONY: test_fhe_strings # Run tests for fhe_strings example | ||
# test_fhe_strings: install_rs_build_toolchain | ||
# RUSTFLAGS="$(RUSTFLAGS)" cargo $(CARGO_RS_BUILD_TOOLCHAIN) test --profile $(CARGO_PROFILE) \ | ||
# --example fhe_strings \ | ||
# --features=$(TARGET_ARCH_FEATURE),integer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be removed or add a target to run string tests and make sure it runs in the CI
59eeb63
to
2bd15e5
Compare
Hum, thing is that I would provably move the, is the create_trivial_ascii from the ClientKey to the ServerKey as its what exists for integers, imo makes a bit more sense as the user could need the ability to create trivial data, and might prevent user from mistaking trivial as a real encryption |
I agree it makes more sense to have it on the ServerKey. What do you think? |
2bd15e5
to
1d0cbc0
Compare
That's ok i think |
.unwrap() | ||
.encryption_key_choice() | ||
{ | ||
EncryptionKeyChoice::Big => self.large_lwe_secret_key().lwe_dimension().to_lwe_size(), | ||
EncryptionKeyChoice::Small => self.small_lwe_secret_key().lwe_dimension().to_lwe_size(), | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameters should already have a encryption_lwe_dimension
function
let pbs_order = match params.encryption_key_choice() { | ||
EncryptionKeyChoice::Big => PBSOrder::KeyswitchBootstrap, | ||
EncryptionKeyChoice::Small => PBSOrder::BootstrapKeyswitch, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PBSOrder::from(params.encryption_key_choice)
No description provided.