-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to check compiler version #4077
Merged
kaidokert
merged 2 commits into
youtube:25.lts.1+
from
niranjanyardi:check_clang_version
Sep 3, 2024
Merged
Add test to check compiler version #4077
kaidokert
merged 2 commits into
youtube:25.lts.1+
from
niranjanyardi:check_clang_version
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
force-pushed
the
check_clang_version
branch
2 times, most recently
from
August 30, 2024 19:58
d0a497d
to
32902d1
Compare
kaidokert
reviewed
Aug 30, 2024
starboard/nplb/compiler_compliance/cpp_compiler_version_check.cc
Outdated
Show resolved
Hide resolved
niranjanyardi
force-pushed
the
check_clang_version
branch
from
August 30, 2024 21:36
32902d1
to
b160bae
Compare
niranjanyardi
force-pushed
the
check_clang_version
branch
from
August 30, 2024 22:16
b160bae
to
42b6950
Compare
kaidokert
reviewed
Sep 2, 2024
starboard/nplb/compiler_compliance/cpp_compiler_version_check.cc
Outdated
Show resolved
Hide resolved
kaidokert
reviewed
Sep 2, 2024
starboard/nplb/compiler_compliance/cpp_compiler_version_check.cc
Outdated
Show resolved
Hide resolved
kaidokert
reviewed
Sep 2, 2024
starboard/nplb/compiler_compliance/cpp_compiler_version_check.cc
Outdated
Show resolved
Hide resolved
kaidokert
reviewed
Sep 2, 2024
starboard/nplb/compiler_compliance/cpp_compiler_version_check.cc
Outdated
Show resolved
Hide resolved
kaidokert
reviewed
Sep 2, 2024
starboard/nplb/compiler_compliance/cpp_compiler_version_check.cc
Outdated
Show resolved
Hide resolved
starboard/nplb/compiler_compliance/cpp_compiler_version_check.cc
Outdated
Show resolved
Hide resolved
niranjanyardi
force-pushed
the
check_clang_version
branch
3 times, most recently
from
September 3, 2024 22:51
77186f6
to
4ab8e7a
Compare
kaidokert
approved these changes
Sep 3, 2024
Change-Id: Id96eae79c6140074b154c0c987b770f24f4dd19c
niranjanyardi
force-pushed
the
check_clang_version
branch
from
September 3, 2024 22:54
4ab8e7a
to
e09720b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/356067446
Add check to compile nplb with clang17 or higher