Skip to content

Commit

Permalink
Add test to check compiler version
Browse files Browse the repository at this point in the history
Change-Id: Id96eae79c6140074b154c0c987b770f24f4dd19c
  • Loading branch information
niranjanyardi committed Aug 30, 2024
1 parent 358cf63 commit d0a497d
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 0 deletions.
1 change: 1 addition & 0 deletions starboard/nplb/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ target(gtest_target_type, "nplb") {

sources = [
"//starboard/common/test_main.cc",
"//starboard/nplb/compiler_compliance/cpp_compiler_version_check.cc",
"//starboard/nplb/sabi/alignment_test.cc",
"//starboard/nplb/sabi/endianness_test.cc",
"//starboard/nplb/sabi/signedness_and_size_of_enum_test.cc",
Expand Down
28 changes: 28 additions & 0 deletions starboard/nplb/compiler_compliance/cpp_compiler_version_check.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// Copyright 2024 The Cobalt Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the aLicense is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#include <iostream>

#ifdef __clang__
// Check if Clang major version is greater than 17.
// Clang major version can be deduced from "clang_revision" in
// starboard/build/config/clang.gni
static_assert(
__clang_major__ >= 17,
"We compile above starboard targets like cobalt, nplb with "
"clang17 or higher. If you are building non-modularly or with a non-cobalt "
"provided toolchain you may run into this issue. There are 2 ways around "
"this : 1)Build libnplb modularly using the evergreen toolchain."
"2)Update the toolchain used to build nplb to clang17 or higher versions.");
#endif // __clang__

0 comments on commit d0a497d

Please sign in to comment.