Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable_h2 and matching h5vcc.settings #3979

Merged
merged 1 commit into from
Aug 13, 2024

Add disable_h2 and matching h5vcc.settings

0b88c8d
Select commit
Loading
Failed to load commit list.
Merged

Add disable_h2 and matching h5vcc.settings #3979

Add disable_h2 and matching h5vcc.settings
0b88c8d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 13, 2024 in 1s

57.67% (-0.08%) compared to 20d2e12

View this Pull Request on Codecov

57.67% (-0.08%) compared to 20d2e12

Details

Codecov Report

Attention: Patch coverage is 24.39024% with 31 lines in your changes missing coverage. Please review.

Project coverage is 57.67%. Comparing base (20d2e12) to head (0b88c8d).
Report is 2 commits behind head on main.

Files Patch % Lines
cobalt/network/url_request_context.cc 33.33% 12 Missing ⚠️
cobalt/h5vcc/h5vcc_settings.cc 8.33% 11 Missing ⚠️
cobalt/network/network_module.cc 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3979      +/-   ##
==========================================
- Coverage   57.74%   57.67%   -0.08%     
==========================================
  Files        1768     1746      -22     
  Lines       86446    86295     -151     
==========================================
- Hits        49918    49768     -150     
+ Misses      36528    36527       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.