Add disable_h2 and matching h5vcc.settings #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a command-line switch `disable_h2` that disables the HTTP/2 protocol (spdy), and a matching `h5vcc.settings` parameter 'HTTP2' (with backing by `PersistentSettings`) for run-time disabling of HTTP/2 and spdy. Similar to 'QUIC' and 'HTTP3', the setting takes effect immediately for new connections only. This also ensures that when the command-line parameter `disable_quic` or the new `disable_h2` is used, that that can not be overuled later with `5vcc.settings` or from the corresponding `PersistentSetting`. b/205134049
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3979 +/- ##
==========================================
- Coverage 57.74% 57.67% -0.08%
==========================================
Files 1768 1746 -22
Lines 86446 86295 -151
==========================================
- Hits 49918 49768 -150
+ Misses 36528 36527 -1 ☔ View full report in Codecov by Sentry. |
kaidokert
approved these changes
Aug 13, 2024
kaidokert
added
cp-25.lts.1+
johnxwork
reviewed
Aug 13, 2024
| application_settings_[kProtoHTTP2] = {}; | ||
| } | ||
| } else { | ||
| if (next_protos_.back() == kProtoHTTP2) { |
There was a problem hiding this comment.
Is it guaranteed that HTTP2 is at the end of supported protocol list? Even for without our addition?
There was a problem hiding this comment.
Yes, it's only added here and in the constructor.
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
This adds a command-line switch `disable_h2` that disables the HTTP/2 protocol (spdy), and a matching `h5vcc.settings` parameter 'HTTP2' (with backing by `PersistentSettings`) for run-time disabling of HTTP/2 and spdy. Similar to 'QUIC' and 'HTTP3', the setting takes effect immediately for new connections only. This also ensures that when the command-line parameter `disable_quic` or the new `disable_h2` is used, that that can not be overuled later with `5vcc.settings` or from the corresponding `PersistentSetting`. b/205134049 (cherry picked from commit 2ca4fc9)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
This adds a command-line switch `disable_h2` that disables the HTTP/2 protocol (spdy), and a matching `h5vcc.settings` parameter 'HTTP2' (with backing by `PersistentSettings`) for run-time disabling of HTTP/2 and spdy. Similar to 'QUIC' and 'HTTP3', the setting takes effect immediately for new connections only. This also ensures that when the command-line parameter `disable_quic` or the new `disable_h2` is used, that that can not be overuled later with `5vcc.settings` or from the corresponding `PersistentSetting`. b/205134049 (cherry picked from commit 2ca4fc9)
jellefoks
added a commit
that referenced
this pull request
Aug 13, 2024
Refer to the original PR: #3979 This adds a command-line switch `disable_h2` that disables the HTTP/2 protocol (spdy), and a matching `h5vcc.settings` parameter 'HTTP2' (with backing by `PersistentSettings`) for run-time disabling of HTTP/2 and spdy. Similar to 'QUIC' and 'HTTP3', the setting takes effect immediately for new connections only. This also ensures that when the command-line parameter `disable_quic` or the new `disable_h2` is used, that that can not be overuled later with `5vcc.settings` or from the corresponding `PersistentSetting`. b/205134049 Co-authored-by: Jelle Foks <[email protected]>
kaidokert
pushed a commit
that referenced
this pull request
Aug 13, 2024
Refer to the original PR: #3979 This adds a command-line switch `disable_h2` that disables the HTTP/2 protocol (spdy), and a matching `h5vcc.settings` parameter 'HTTP2' (with backing by `PersistentSettings`) for run-time disabling of HTTP/2 and spdy. Similar to 'QUIC' and 'HTTP3', the setting takes effect immediately for new connections only. This also ensures that when the command-line parameter `disable_quic` or the new `disable_h2` is used, that that can not be overuled later with `5vcc.settings` or from the corresponding `PersistentSetting`. b/205134049 Co-authored-by: Jelle Foks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a command-line switch
disable_h2that disables the HTTP/2 protocol (spdy), and a matchingh5vcc.settingsparameter 'HTTP2' (with backing byPersistentSettings) for run-time disabling of HTTP/2 and spdy. Similar to 'QUIC' and 'HTTP3', the setting takes effect immediately for new connections only.This also ensures that when the command-line parameter
disable_quicor the newdisable_h2is used, that that can not be overuled later with5vcc.settingsor from the correspondingPersistentSetting.b/205134049