Cherry pick PR #3979: Add disable_h2 and matching h5vcc.settings #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-24.lts.1+-3979 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/10377019661 for details. |
jellefoks
force-pushed
the
cherry-pick-24.lts.1+-3979
branch
from
0f1f05a
to
f4cee50
Compare
Pushed an update for this branch. |
kaidokert
approved these changes
Aug 13, 2024
jellefoks
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3979
This adds a command-line switch
disable_h2that disables the HTTP/2 protocol (spdy), and a matchingh5vcc.settingsparameter 'HTTP2' (with backing byPersistentSettings) for run-time disabling of HTTP/2 and spdy. Similar to 'QUIC' and 'HTTP3', the setting takes effect immediately for new connections only.This also ensures that when the command-line parameter
disable_quicor the newdisable_h2is used, that that can not be overuled later with5vcc.settingsor from the correspondingPersistentSetting.b/205134049